853819 - VKB does not appear when tapping on text inputs on flash sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Catalin Suciu [:csuciu]]

Nightly 22.0a1 (2013-03-21)
Galaxy Nexus (4.1.1), Samsung Galaxy Note (4.0.4)

Steps: 
1. Go to http://www.zasmakujelegancji.pl/
2. Tap on one of the text inputs (day/month/year)

Expected: VKB appears
Actual: Nothing happens

Also happens on http://www.tizag.com/pics/flash/form1easy.swf

Regression window:
Good build: 2013-03-05
Bad build: 2013-03-06

Possible range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=015da7030aab&tochange=216ec69cc531

Comment 1

[Aaron Train [:aaronmt]]

Bug 843048?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Bug 843048 actually.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use focused window to process SetInputContext and GetInputContext (v1)

In bug 843048, we switched to using an IME event to notify Java during SetInputContext calls. However, IME events are processed by the focused window, which is not necessarily the top window. So we need to let the focused window process the SetInputContext call too, to ensure saved states are consistent.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 728300 [details] [diff] [review]
Use focused window to process SetInputContext and GetInputContext (v1)

Review of attachment 728300 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf185b01f0ca

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf185b01f0ca

Comment 7

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 22.0a1 (2013-03-28)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1