853820 - Doorhanger buttons slightly cut off when dynamic toolbar is hidden

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Peter Retzer (:pretzer)]

Attachment: Screenshot of the issue

STR:
1) Go to www.google.com
2) Hide the toolbar by scolling it off the screen
3) Hit the 'Use precise location' link to invoke a geolocation doorhanger
4) Do the the same with the toolbar visible and compare the dimensions of the two doorhangers (note: you have to reload the page to make the doorhanger reappear first)

Actual:
The doorhanger is slightly cut off at the bottom when the toolbar is hidden.

Expected:
The doorhanger should look the same as when the toolbar is visible.

Comment 1

[Chris Lord [:cwiiis]]

Could someone from front-end have a look at this?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - Take a look?

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

PopupWindow shrinks if it is shown outside window bounds. So, when the anchor is way past the Window, the PopupWindow shrinks. This patch makes sure to align it to browser's top in that case.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/acd66f626f5e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/acd66f626f5e

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - needs uplift, right?