Closed Bug 853867 Opened 8 years ago Closed 8 years ago

GTest (via --enable-gtest) doesn't build on Android

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

Attachments

(1 file, 2 obsolete files)

Patch incoming.
This lets a --enable-gtest build to finish on Android-x86 for me - I've done no further testing yet.
Attachment #728226 - Flags: review?(bgirard)
Comment on attachment 728226 [details] [diff] [review]
Allow --enable-gtest on Android and fix build issues

bas for moz2d tests.
Attachment #728226 - Flags: review?(bgirard)
Attachment #728226 - Flags: review?(bas)
Attachment #728226 - Flags: review+
Duplicate of this bug: 846356
Comment on attachment 728226 [details] [diff] [review]
Allow --enable-gtest on Android and fix build issues

Review of attachment 728226 [details] [diff] [review]:
-----------------------------------------------------------------

This comment applies for all places! :-)

::: gfx/2d/unittest/TestScaling.cpp
@@ +22,5 @@
>  
>  void
>  TestScaling::BasicHalfScale()
>  {
> +  uint32_t *pixels = new uint32_t[500*500];

Don't do this :-)

@@ +31,5 @@
>        pixels[(y + 1) * 500 + x] = 0xff000000;
>        pixels[(y + 1) * 500 + x + 1] = 0xff0000ff;
>      }
>    }
> +  ImageHalfScaler scaler(reinterpret_cast<uint8_t*>(pixels), 500 * 4, IntSize(500, 500));

&data.front()
Attachment #728226 - Flags: review?(bas) → review-
Got time to finish this cwiiis? I'm looking into getting this to run on buildbot to give mobile some APZC tests.
Depends on: gtest
Attachment #728226 - Attachment is obsolete: true
Attachment #741975 - Flags: review?(bas)
Comment on attachment 741975 [details] [diff] [review]
Allow --enable-gtest on Android and fix build issues v2

Review of attachment 741975 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/unittest/TestScaling.cpp
@@ +25,5 @@
>  {
>    std::vector<uint8_t> data;
>    data.resize(500 * 500 * 4);
>  
> +  uint32_t *pixels = (uint32_t*)&data.front();

C++ casts, please.
Attachment #741986 - Flags: review?(bas)
Attachment #741986 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/5fb2a77bb0db
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.