Closed Bug 853946 Opened 10 years ago Closed 10 years ago

Replace flex container's cached content-box height & ascent with local variables in Reflow()

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

fix
5.92 KB, patch
Details | Diff | Splinter Review 
Before bug 851607 landed, we cached flex-container content-box-height and ascent (baseline) on the frame, so that non-dirty reflows could use the cached values without having to inspect the children.

However, now that we're unconditionally reflowing the children (bug 851607), we don't need to cache these values anymore -- they can just be replaced with local variables in Reflow().
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch fix — — Splinter Review
Summary: Remove cached content-box height & ascent from nsFlexContainerFrame → Replace flex container's cached content-box height & ascent with local variables in Reflow()
Blocks: 785468
d'oh, I could've sworn I'd requested r?dbaron on this, but I guess I didn't.

The patch is straightforward enough that it doesn't really require much flexbox-specific knowledge, I think, so I just ran it by Waldo IRL, and he was happy to rubber-stamp it (and I it's a trivial enough patch that rubber-stamp style review is sufficient).

Landing shortly.
https://hg.mozilla.org/mozilla-central/rev/b2cb3d603fa6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.