853996 - A menu command and the shortcut bring a different effect in permanent private browsing

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Eiichi]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID: 20130320062118




Expected results:

On Firefox 20 beta 6 (20130320062118), Mac OSX 10.7.5;
1. Clicking "New Private Window" of File menu opens the "about:private browsing".
2. "Command + N" shortcut opens the page that users set in "Preferences > General > When Firefox starts".

This is derived from Bug 845592.

Comment 1

[Eiichi]

 "Command + Shift + P" shortcut also opens the page that users set in "Preferences > General > When Firefox starts".
So Clicking "New Private Window" of File menu opens the page that users set in "Preferences > General > When Firefox starts".

Comment 2

[Eiichi]

This happens when Firefox opens one or more windows.
This doesn't happen when Firefox opens no windows.

Comment 3

[Eiichi]

Sorry for my mistake that may elicit misunderstanding.

Now when Firefox 20 beta 6 has one or more windows,
-Hitting "Command + N" opens the page that users set in "Preferences > General > When Firefox starts".
-Clicking "New Private Window" of File menu opens the "about:private browsing".

Expected results:
Clicking "New Private Window" of File menu should open the page that users set in "Preferences > General > When Firefox starts".

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[(no longer active)]

Comment on attachment 728733 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): pbngen
User impact if declined: See the description
Testing completed (on m-c, etc.): Locally
Risk to taking this patch (and alternatives if risky): Very minimal
String or UUID changes made by this patch: none

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0373ca9b42ef

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0373ca9b42ef

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 728733 [details] [diff] [review]
Patch (v1)

Approving the low risk patch on aurora .This helps respect user setting when opening a new PBW via command+N or "New Private Browsing" resulting into opening the window set by the user via "Preferences > General > When Firefox starts".

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 728733 [details] [diff] [review]
Patch (v1)

Will take this for our final FF20 beta - needs to land asap.

Testing around this should be a priority when the final beta build is ready:
* Opening new window with shortcut vs. menu item
* Go to private browsing mode, create a new window (shortcut & menu)
* In permanent PB mode, create a new window (shortcut & menu)

We should confirm consistency across all of those use cases.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Ehsan are you around for a quick uplift here - i'm currently casting around on #developers for someone to get this in within the hour.

Comment 11

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7a5e69391ad
https://hg.mozilla.org/releases/mozilla-beta/rev/116acfdc5059

Comment 12

[Ioana (away)]

Verified as fixed on Firefox 20 beta 7 - 20130325214615.

Both Cmd+N and File->New Private Window open what is set in Preferences > General > When Firefox starts.

Comment 13

[Tiziana Sellitto [:tiziana]]

Verified fixed on Firefox 21 beta 1 - 20130401192816: 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0

Verified fixed on Firefox Aurora 22.0a2 – 20130407004016: 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:22.0) Gecko/20130407 Firefox/22.0

Comment 14

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old