854025 - Opening an alert service notification crashes my browser

Status: RESOLVED DUPLICATE of bug 852436

(Core :: DOM: Core & HTML, defect)

Description

[Dave Townsend [:mossop]]

Example crash: https://crash-stats.mozilla.com/report/index/bp-dfef3ec5-24c9-461b-a145-9ad452130322

Everytime a download completes and it attempts to show the alert service notification my firefox crashes. The line numbers suggest this starts in code from bug 782211 though the signature is very similar to bug 852436.

This is 100% reproducible for me and very annoying.

Comment 1

[Dave Townsend [:mossop]]

I've discovered that if I focus some other application before the alert opens then Firefox doesn't crash and the alert shows in the upper-left corner until dismissed, i.e. it doesn't automatically close after a short time.

Comment 2

[Justin Dolske [:Dolske]]

I _might_ be hitting this: tried to close a notification that wasn't going away, and immediately crashed w/o the crashreporter -- :( :( :(. The stack I got from Apple's thing was http://pastebin.mozilla.org/2238668

Nothing obvious about notifications there, though. Also OSX instead of Win7.

Comment 3

[William Chen [:wchen]]

I'm looking into this.

Comment 4

[Robert Kaiser]

Not sure if this isn't actually a dupe of bug 852436.

Comment 5

[William Chen [:wchen]]

Attachment: Don't pass window as argument when opening new window for alerts service.

After reading the comments in bug 852436 I suspect the crashes we are seeing are related to my changes to the XUL alerts. In particular, I pass the previous alert window as an argument to nsIWindowWatcher::OpenWindow and this eventually calls WrapNative with a non-inner window. Oops. The previous alert window was only passed so that the new alert could replace it, but the patch I've attached will close the previous alert and create a new one which is still compatible with the notification spec.

Comment 6

[Dave Townsend [:mossop]]

If you want to spin a try build for this I can verify it fixes my crashes tomorrow

Comment 7

[William Chen [:wchen]]

Comment on attachment 730459 [details] [diff] [review]
Don't pass window as argument when opening new window for alerts service.

After talking with mrbkap about this, it looks like this happens because of bug 852436 and the patch attached there seems to fix this problem.

Comment 8

[Tracy Walker [:tracy]]

marking dupe per comment 7.  If that fix turns out not to address this issue, we'll reopen this for investigation.

Comment 9

[Dave Townsend [:mossop]]

I'm no longer crashing when alert notifications are meant to happen, so that's awesome. However it looks like alert notifications just don't appear anymore.