854028 - New mochitests for Power Management API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Luqman Aden [:Luqman]]

Some sanity tests for the Power API.

Comment 1

[Luqman Aden [:Luqman]]

Attachment: Power api tests.

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 728489 [details] [diff] [review]
Power api tests.

Review of attachment 728489 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/power/test/Makefile.in
@@ +19,4 @@
>    $(NULL)
>  
>  MOCHITEST_BROWSER_FILES = \
> +  browser_wakelocks.js \

This file is not renamed in this patch right?

::: dom/power/test/test_power_set_screen_enabled.html
@@ +15,5 @@
> +  "use strict";
> +
> +  function testEnableScreen() {
> +    try {
> +      navigator.mozPower.screenEnabled = true;

If this is running on a real device then it might suspend the device here. Maybe set navigator.mozPower.cpuSleepAllowed to false first?

Comment 3

[Luqman Aden [:Luqman]]

(In reply to Kan-Ru Chen [:kanru] from comment #2)
> Comment on attachment 728489 [details] [diff] [review]
> Power api tests.
> 
> Review of attachment 728489 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/power/test/Makefile.in
> @@ +19,4 @@
> >    $(NULL)
> >  
> >  MOCHITEST_BROWSER_FILES = \
> > +  browser_wakelocks.js \
> 
> This file is not renamed in this patch right?

It is renamed:
>diff --git a/dom/power/test/browser_bug697132.js b/dom/power/test/browser_wakelocks.js
>rename from dom/power/test/browser_bug697132.js
>rename to dom/power/test/browser_wakelocks.js


> 
> ::: dom/power/test/test_power_set_screen_enabled.html
> @@ +15,5 @@
> > +  "use strict";
> > +
> > +  function testEnableScreen() {
> > +    try {
> > +      navigator.mozPower.screenEnabled = true;
> 
> If this is running on a real device then it might suspend the device here.
> Maybe set navigator.mozPower.cpuSleepAllowed to false first?

I'm not sure whether the tests are run on an actual device, but it can't hurt to set this.

Comment 4

[Luqman Aden [:Luqman]]

Attachment: Alarm api tests.

Comment 5

[Luqman Aden [:Luqman]]

Here's the try run from Friday:
https://tbpl.mozilla.org/?tree=Try&rev=6c88ce9c75bf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5bd0c5a4cba

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5bd0c5a4cba