Closed Bug 854045 Opened 9 years ago Closed 9 years ago

Enable OdinMonkey on x86 Android

Categories

(Core :: JavaScript Engine, defect)

x86
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(2 files)

x86 Android wouldn't have a problem, it's just Linux+x86, except that the NDK headers are missing mcontext_t.  Fortunately, there is a common workaround.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=fcde429b383d
Attachment #728516 - Flags: review?(mrosenberg)
Green on try, fwiw.
Comment on attachment 728516 [details] [diff] [review]
add mcontext_t for Android

doh, we should've r+d this a week ago! :)
Attachment #728516 - Flags: review?(mrosenberg) → review+
Attached patch Rebased.Splinter Review
Re-base after bug 851880 landed.  Note the ARM support has also been included in bug 840285, but the patch here is more comprehensive so perhaps this could be landed first.  Tested on ARM Android.
Comment on attachment 728516 [details] [diff] [review]
add mcontext_t for Android

Review of attachment 728516 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/AsmJS.h
@@ +13,5 @@
>  # include <mach/mach.h>
>  #endif
>  
>  // asm.js compilation is only available on desktop x86/x64 at the moment.
>  // Don't panic, mobile support is coming soon.

Shouldn't this comment be updated?
Yes it should
https://hg.mozilla.org/mozilla-central/rev/b8064310b2b2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.