854045 - Enable OdinMonkey on x86 Android

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: add mcontext_t for Android

x86 Android wouldn't have a problem, it's just Linux+x86, except that the NDK headers are missing mcontext_t.  Fortunately, there is a common workaround.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=fcde429b383d

Comment 1

[Luke Wagner [:luke]]

Green on try, fwiw.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 728516 [details] [diff] [review]
add mcontext_t for Android

doh, we should've r+d this a week ago! :)

Comment 3

[Douglas Crosher [:dougc]]

Attachment: Rebased.

Re-base after bug 851880 landed.  Note the ARM support has also been included in bug 840285, but the patch here is more comprehensive so perhaps this could be landed first.  Tested on ARM Android.

Comment 4

[Luke Wagner [:luke]]

Thanks Douglas!
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8064310b2b2

Comment 5

[:Benjamin Peterson]

Comment on attachment 728516 [details] [diff] [review]
add mcontext_t for Android

Review of attachment 728516 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/AsmJS.h
@@ +13,5 @@
>  # include <mach/mach.h>
>  #endif
>  
>  // asm.js compilation is only available on desktop x86/x64 at the moment.
>  // Don't panic, mobile support is coming soon.

Shouldn't this comment be updated?

Comment 6

[Luke Wagner [:luke]]

Yes it should

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8064310b2b2