85408 - clean up XSLTProcessor.cpp

Status: VERIFIED FIXED

(Core :: XSLT, defect, P5)

Description

[Axel Hecht]

remove unused code from XSLTProcessor.cpp, clean up the logic, remove
wallpaper functions.

XSLType::CALL_TEMPLATE has code that moved to other functions,
XSLType::CALL_TEMPLATE has a if ( xslTemplate ) { alot of code, those should
be converted to early breaks.
There are alot of no-brainer convenience functions, which more or less just
clutter the code, namely half of the ::process() functions.

Axel

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

|XSLTProcessor::processTopLevel(Document* xslDocument ...| should go to IMHO.
It's just a matter of doing |processTopLevel(document.getDocumentElement(),...| 
rather then |processTopLevel(document,...|

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

On second thought maybe
|XSLTProcessor::processTopLevel(Document* xslDocument ...| is a good place to 
handle LRE stylesheets (section 2.3 of spec)

Comment 3

[Peter Van der Beken [:peterv]]

I'll attach a first patch. I've had this for a couple of months, brought it up
to date with the current tree. It's a draft, it won't compile on standalone and
needs more cleanup. Warning: lot's of code shifting and cleanup, so prepare for
merge hell if you want to apply this. If anyone works on this, let me know.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Draft

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

this is very much done on the branch

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

fixed with the branch-landing, yeah baby

Comment 7

[Axel Hecht]

mass verifying