Closed Bug 85408 Opened 23 years ago Closed 22 years ago

clean up XSLTProcessor.cpp

Categories

(Core :: XSLT, defect, P5)

defect

Tracking

()

VERIFIED FIXED
Future

People

(Reporter: axel, Assigned: peterv)

References

Details

Attachments

(1 file)

remove unused code from XSLTProcessor.cpp, clean up the logic, remove
wallpaper functions.

XSLType::CALL_TEMPLATE has code that moved to other functions,
XSLType::CALL_TEMPLATE has a if ( xslTemplate ) { alot of code, those should
be converted to early breaks.
There are alot of no-brainer convenience functions, which more or less just
clutter the code, namely half of the ::process() functions.

Axel
|XSLTProcessor::processTopLevel(Document* xslDocument ...| should go to IMHO.
It's just a matter of doing |processTopLevel(document.getDocumentElement(),...| 
rather then |processTopLevel(document,...|
On second thought maybe
|XSLTProcessor::processTopLevel(Document* xslDocument ...| is a good place to 
handle LRE stylesheets (section 2.3 of spec)
I'll attach a first patch. I've had this for a couple of months, brought it up
to date with the current tree. It's a draft, it won't compile on standalone and
needs more cleanup. Warning: lot's of code shifting and cleanup, so prepare for
merge hell if you want to apply this. If anyone works on this, let me know.
Assignee: kvisco → peterv
Attached patch DraftSplinter Review
Priority: -- → P5
Target Milestone: --- → Future
this is very much done on the branch
Depends on: txbranch
fixed with the branch-landing, yeah baby
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
mass verifying
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: