854141 - Keyboard shortcut sent to underlying page

Status: RESOLVED DUPLICATE of bug 380637

(Firefox :: Untriaged, defect)

Description

[Bruno 'Aqualon' Escherl]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/20100101 Firefox/19.0 SeaMonkey/2.16.2
Build ID: 20130310200905

Steps to reproduce:

STR:

- Go to https://www.xing.com/
- Open a new tab, load any page there and close it again
- On the tab with https://www.xing.com/ make sure you don't have focus
on the login input box
- Press Ctrl+Shift+T to get the closed tab back.


Actual results:

The closed tab is reopened as expected, but also on xing.com a
Javascript listening to Shift+T is triggered and gets you to
https://www.xing.com/topics


Expected results:

Browser shortcuts should probably not be sent to the open site.

Comment 1

[Bruno 'Aqualon' Escherl]

Login on xing.com is not necessary, the Shift+T shortcut also works logged out. And I see this in Firefox 19.0.2 and Seamonkey 2.16.2 (filled the bug with SeaMonkey)

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Bruno 'Aqualon' Escherl from comment #1)
> Login on xing.com is not necessary, the Shift+T shortcut also works logged
> out. And I see this in Firefox 19.0.2 and Seamonkey 2.16.2 (filled the bug
> with SeaMonkey)

Not for me, I need to be logged in to have any access to the topics page.

If the above STR do not work try these:

- Go to https://www.xing.com/
- Log In
- Open a new tab and close it again
- On the tab with https://www.xing.com/ make sure you have the content 
window focussed but don't have focus in the input box
- Press Ctrl+Shift+T to get the closed tab back.

Whether we are handling this correctly depends whether "Undo close tab" 
is triggered before or after the page events.

Either XING don't call event.preventDefault() when choosing the topic 
page or we don't cancel it when "Undo close tab" is triggered.

Comment 3

[Bruno 'Aqualon' Escherl]

:dholbert pointed to bug 380637, so maybe it's just another dupe.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug 380637 is about whether webpages should be allowed to override browser shortcuts. If they were allowed to do that then this could introduce security issues but if they were not we have this kind of issue.

So, yes, I guess this is a dupe.