854174 - Chrome debugging should use its own port to avoid interfering with remote port changes

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Since there's currently no way of passing settings around between firefox instances when initializing the browser debugger process, the server initialization port and the client connection port may end up being different across the two profiles. This is especially obvious when the Firefox OS simulator dashboard changes the port pref.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 728710 [details] [diff] [review]
v1

Review of attachment 728710 [details] [diff] [review]:
-----------------------------------------------------------------

Just a couple of minor issues, but otherwise it looks good.

::: browser/app/profile/firefox.js
@@ +1056,5 @@
>  // Enable the Debugger
>  pref("devtools.debugger.enabled", true);
>  pref("devtools.debugger.chrome-enabled", true);
> +pref("devtools.debugger.chrome-debugging-host", "localhost");
> +pref("devtools.debugger.chrome-debugging-port", 6123);

Could we pick a port number that is unassigned this time? 6080 seems like a good one:

https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.txt

::: browser/devtools/debugger/DebuggerUI.jsm
@@ +10,5 @@
>  const Cu = Components.utils;
>  
>  const DBG_XUL = "chrome://browser/content/debugger.xul";
>  const DBG_STRINGS_URI = "chrome://browser/locale/devtools/debugger.properties";
> +const CHROME_DEBUGGER_PROFILE_NAME = "-chrome-debugger";

Could you avoid changing this? Every time we change the profile name, garbage gets accumulated in people's computers, because nobody besides us is going to remove the obsolete profiles.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> 
> Could you avoid changing this? Every time we change the profile name,
> garbage gets accumulated in people's computers, because nobody besides us is
> going to remove the obsolete profiles.

Not really, I'm changing the profile name because otherwise the prefs won't be updated (the old profile won't know about the new chrome-debugging-* prefs).

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> 
> Could we pick a port number that is unassigned this time? 6080 seems like a
> good one:
> 
> https://www.iana.org/assignments/service-names-port-numbers/service-names-
> port-numbers.txt
> 

Good idea. What do you think about making the default chrome debugging port to 6081 and change the remote debugging port to 6080? This will also make
> user_pref("devtools.debugger.remote-port", 6023);
in automation.py unnecessary (which I'd say is a good thing) and probably help us avoid any pain we may ever encounter.

I know the simulator is being smart about this, but still..

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof [:vp] from comment #3)
> (In reply to Panos Astithas [:past] from comment #2)
> > 
> > Could you avoid changing this? Every time we change the profile name,
> > garbage gets accumulated in people's computers, because nobody besides us is
> > going to remove the obsolete profiles.
> 
> Not really, I'm changing the profile name because otherwise the prefs won't
> be updated (the old profile won't know about the new chrome-debugging-*
> prefs).

Ugh, OK then.

(In reply to Victor Porof [:vp] from comment #4)
> (In reply to Panos Astithas [:past] from comment #2)
> > 
> > Could we pick a port number that is unassigned this time? 6080 seems like a
> > good one:
> > 
> > https://www.iana.org/assignments/service-names-port-numbers/service-names-
> > port-numbers.txt
> > 
> 
> Good idea. What do you think about making the default chrome debugging port
> to 6081 and change the remote debugging port to 6080? This will also make
> > user_pref("devtools.debugger.remote-port", 6023);
> in automation.py unnecessary (which I'd say is a good thing) and probably
> help us avoid any pain we may ever encounter.
> 
> I know the simulator is being smart about this, but still..

6081 has been used by a trojan, so I'm worried that we might trigger warnings from anti-virus programs.

I'd also rather not change the default remote port at this point, because it has been widely used and documented, and I don't think it makes sense to break working configurations for users without a significant gain.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1.1

Changed default chrome debugging port to 6080.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/983d8a7b4cea

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/983d8a7b4cea