854209 - add asm.js mochitests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

OdinMonkey has a bunch of unit tests in js/src/jit-tests/tests/asm.js, but we need some browser tests as well:
 - crashing with asm.js (testing breakpad)
 - out-of-bounds and slow-script exceptions handled by Odin
 - asm.js code running in a web worker
 - something non-trivial like zlib

Comment 1

[Alon Zakai (:azakai)]

A web worker test is in 854197, hope it's helpful.

Comment 2

[Alon Zakai (:azakai)]

Bug 854197, I meant.

Comment 3

[Luke Wagner [:luke]]

Ted: I'd like to write a mochitest that runs asm.js, triggers some faults that the asm.js signal handler handles, then triggers a real crash that breakpad handles.  Is there any way to do this from a mochitest, or does it require xpcshell (which requires 842728 to be fixed)?

Comment 4

[(not currently active) Ted Mielczarek]

You can't crash a Mochitest and handle it. You can crash a plugin or a content process, but I'm not sure if either of those would test what you want. We may need to fix the xpcshell thing to test this properly.

Comment 5

[Luke Wagner [:luke]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
Ah, ok.  Any plans to do that in the near term?  It'd be great to get in an automated test to catch signal handler regressions wrt breakpad.

Comment 6

[Luke Wagner [:luke]]

Attachment: first round of tests

Here's a first round that verifies asm.js optimizations, hits asm.js-handled faults, and runs asm.js code in a worker.

The only thing pending is adding an xpconnect test that the crash handler works when asm.js handlers have been installed (which has been hand-verified, of course).  But that will have to block on bug 842728.

Comment 7

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78802b1601ed

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/78802b1601ed