Closed Bug 854329 Opened 7 years ago Closed 7 years ago

Import more tests

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

No description provided.
Attached patch Part aSplinter Review
Attachment #728885 - Flags: review?(mounir)
Attached patch Part bSplinter Review
Attachment #728886 - Flags: review?(mounir)
Comment on attachment 728885 [details] [diff] [review]
Part a

rs=me, I will not pretend to review all of that.
Attachment #728885 - Flags: review?(mounir)
Comment on attachment 728886 [details] [diff] [review]
Part b

ditto
Attachment #728886 - Flags: review?(mounir)
https://hg.mozilla.org/mozilla-central/rev/3447006848f1
https://hg.mozilla.org/mozilla-central/rev/99d6a2e26c94
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Depends on: 859075
Depends on: 859101
Due to the extremely long path/filenames of some of these tests, this broke Thunderbird builds (bug 859101). Can we please shorten some of the longer paths? The one that broke was tests/dom/imptests/failures/html/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/test_script-IDL-event-htmlfor.html.json, but it looks like there's similarly long tests. Maybe shortening dirs like 'other-elements-attributes-and-apis' and 'requirements-for-implementations' would be best?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 728886 [details] [diff] [review]
Part b

>+++ b/dom/imptests/failures/html/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/test_script-IDL-event-htmlfor.html.json

Yes, this is one of the instances where the Thunderbird build fails. Shortening (and possibly combining) requirements-for-implementations and other-elements-attributes-and-apis should resolve the issue.

>+++ b/dom/imptests/failures/html/html/dom/documents/dom-tree-accessors/document.getElementsByName/test_document.getElementsByName-newelements.html.json

This is the second instance. Generalizing per bug 859101 comment #2, reducing test_document.getElementsByName-* to just test_* would eliminate the problem here.

>+# THIS FILE IS AUTOGENERATED BY parseFailures.py - DO NOT EDIT

This part is somewhat worrisome, so this has been created by an automated tool? If yes, this may imply that any future changes may override anything done here locally whenever those tests are updated coming from W3C unless similar changes are applied before importing new tests or updates to affected existing tests.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.