Closed
Bug 854347
Opened 12 years ago
Closed 12 years ago
[b2g-bluetooth] Failed to receive files after cancelling receiving a file
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:tef+, firefox20 wontfix, firefox21 wontfix, firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)
People
(Reporter: gyeh, Assigned: gyeh)
References
Details
(Whiteboard: [TD-10003])
Attachments
(1 file, 1 obsolete file)
676 bytes,
patch
|
Details | Diff | Splinter Review |
STR
1. Pair with a laptop (Ubuntu)
2. Send a file to Unagi
3. Cancel the transfer from laptop
4. Re-send a file to Unagi
Expected result
* Should be able to receive the file
Actual result
* No reaction
Note that this issue is not always reproducible. It's a timing issue. Sometimes, this issue happened after repeating STR 2 times. Sometimes, it happened after repeating 10 times.
Assignee | ||
Comment 1•12 years ago
|
||
This happenes not only in m-c, but also b2g-18. Nominate tef? flag.
blocking-b2g: --- → tef?
Assignee | ||
Comment 2•12 years ago
|
||
Ok, here's the root cause. We maintained a data member called "mPacketLeftLength" in BluetoothOppManager. For each Put packet, we set mPacketLeftLength according to the information from packet header and set mPacketLeftLength. A packet is split into several parts and mPacketLeftLength is updated then. When a packet is completely received in BluetoothOppManager, start processing the patcket.
However, it may be possible that the transfer is cancelled during collecting all parts of a packet, and the socket is closed without reset mPacketLeftLength. As a result, we failed to recognize a new Put packet in the next transfer.
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #728919 -
Flags: review?(echou)
Comment 4•12 years ago
|
||
Comment on attachment 728919 [details] [diff] [review]
Patch 1(v1): Reset mPacketLeftLength after opp disconnected
Review of attachment 728919 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch!
Attachment #728919 -
Flags: review?(echou) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #728919 -
Attachment is obsolete: true
Updated•12 years ago
|
Summary: [b2g-bluetooth] Failed to receive files after calcelling receiving a file → [b2g-bluetooth] Failed to receive files after cancelling receiving a file
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2G C4 (2jan on)
Updated•12 years ago
|
Comment 8•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/f5e8a99a999e
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/589e30787f31
status-b2g18-v1.0.0:
--- → wontfix
status-firefox20:
--- → wontfix
status-firefox21:
--- → wontfix
status-firefox22:
--- → fixed
The issue is fixed on Unagi Build ID: 20130404070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e43e65ec89d2
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7
I tried to reproduce this defect about 5 times and could not. I was able to receive a file.
Verified Fixed
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•