854353 - [Buri][USB tethering]Computer cann't surf Internet when switch Wi-Fi to mobile data

Status: RESOLVED DUPLICATE of bug 868913

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #427576 +++
 
 DEFECT DESCRIPTION:
 Computer cann't surf Internet when switch Wi-Fi to mobile data
 REPRODUCING PROCEDURES:
 1.turn on Wi-Fi and connect to AP
 2.data connection is on
 3.Settings->Internet sharing->USB tethering,computer can surf Internet via MS's Wi-Fi
 4.turn off Wi-Fi,computer cann't surf Internet->KO1
 EXPECTED BEHAVIOUR:
 1.after turn off Wi-Fi,computer can surf Internet via mobile data
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:5/5
 
 For FT PR, Please list reference mobile's behavior:
 
 AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.044
 Firefox os  v1.0.1
 Mozilla build ID: 20130319070203
 
 ++++++++++ end of initial bug #427576 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
 DEFECT DESCRIPTION:
 
 REPRODUCING PROCEDURES:
 
 EXPECTED BEHAVIOUR:
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[John Hammink]

Not seeing this on 3/25/13 for Unagi.  It may not be the same, but please describe the steps you used to configure the network connection on your computer.

Comment 2

[Vincent Chang[:vchang][changyihsin]]

We don't re-configure the NAT rules when network interface changes. Need to post a new patch to address this in NetworkManager

Comment 3

[xiaokang.chen]

Dear all,

This bug exist still. For better user experience, can you track and fix this bug.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

I am going to post a patch tomorrow.

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

I know that you have touched usb tethering related code. Can you help to review my patch ?

Comment 7

[Dave Hylands [:dhylands]]

Sure - is it ok if I don't get to it until next week?

Comment 8

[Vincent Chang[:vchang][changyihsin]]

(In reply to Dave Hylands [:dhylands] from comment #7)
> Sure - is it ok if I don't get to it until next week?

Thanks, I am fine with that.

Comment 9

[leo.bugzilla.gecko]

Dear Vincent Chang,

I'm a data engineer of LGE.

I checked this patch with ver v1.1 on the phone.
The result is not OK.
In the first change(Wifi -> 3G), it looks corrected.(can surf the internet after changing)
But in the second change(3G -> Wifi again), USB tethering goes off.(can not surf the internet after changing)

actually, 3G -> Wifi case looks like not considered.

We need fixed patch.

BR,
Jinho Lee.

Comment 10

[leo.bugzilla.gecko]

My email is [e-mail]

Thanks,
Jinho Lee.

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to leo.bugzilla.gecko from comment #9)
> Dear Vincent Chang,
> 
> I'm a data engineer of LGE.
> 
> I checked this patch with ver v1.1 on the phone.
> The result is not OK.
> In the first change(Wifi -> 3G), it looks corrected.(can surf the internet
> after changing)
> But in the second change(3G -> Wifi again), USB tethering goes off.(can not
> surf the internet after changing)
> 
> actually, 3G -> Wifi case looks like not considered.
> 
> We need fixed patch.
> 
> BR,
> Jinho Lee.

Thanks for your feedback, I am trying the on the other device, and it works well. 
Let me see if I can have a Leo phone to check the patch.

Comment 12

[leo.bugzilla.gecko]

Dear Vincent Chang,

Haven't you tested it on Leo phone, yet?
please let me know the result and provide fixed patch if you find the problem I commented before.

BR,
Jinho Lee.

Comment 13

[Vincent Chang[:vchang][changyihsin]]

Hi Jinho, I have tried to reproduce the bug, but the usb hotspot can't be turned on because of Bug 864588. I am wondering why sys.usb.state doesn't work. Do you hit the same bug ? There might be some issues while while porting the B2G to LEO.

Comment 14

[xiaokang.chen]

(In reply to Vincent Chang[:vchang] from comment #13)
> Hi Jinho, I have tried to reproduce the bug, but the usb hotspot can't be
> turned on because of Bug 864588. I am wondering why sys.usb.state doesn't
> work. Do you hit the same bug ? There might be some issues while while
> porting the B2G to LEO.

Dear Vincent,
I have the same issue as Jinho lee said in comment #9. My device is Buri.

Comment 15

[Vincent Chang[:vchang][changyihsin]]

Can I have your STR ? I can't reproduce the problem said in comment #9 after applying the patch. There might be some tricks to reproduce the problem.

Comment 16

[xiaokang.chen]

(In reply to Vincent Chang[:vchang] from comment #15)
> Can I have your STR ? I can't reproduce the problem said in comment #9 after
> applying the patch. There might be some tricks to reproduce the problem.

1. enable wifi, connect to one AP;
2. enable data connection in data and cellular;
3. enable usb tethering and the the pc can surf the internet;
4. disable wifi, pc can surf the internet too;
5. enable wifi again, and the usb tethering turned off automaticlly

Comment 17

[Vincent Chang[:vchang][changyihsin]]

(In reply to xiaokang.chen from comment #16)
> (In reply to Vincent Chang[:vchang] from comment #15)
> > Can I have your STR ? I can't reproduce the problem said in comment #9 after
> > applying the patch. There might be some tricks to reproduce the problem.
> 
> 1. enable wifi, connect to one AP;
> 2. enable data connection in data and cellular;
> 3. enable usb tethering and the the pc can surf the internet;
> 4. disable wifi, pc can surf the internet too;
> 5. enable wifi again, and the usb tethering turned off automaticlly

I followed your STR, but can't reproduce the problem when the patch is applied. May I ask more help ? Not sure if you can provide the logcat log which turn on DEBUG flag to true in NetworkManager.js and net_worker.js. I am wondering if there are errors while issue netd command. 

https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkManager.js#105
https://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/net_worker.js#18

Comment 18

[Leo]

Could you please check again in below S/W version?

-	Build ID : 20130421070203
-	Gaia : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
-	Gecko : 950b402b6188bb2f3ce3176e620ed5249719d720

BR,
Jinho Lee.

Comment 19

[Vincent Liu[:vliu]]

(In reply to Leo from comment #18)
> Could you please check again in below S/W version?
> 
> -	Build ID : 20130421070203
> -	Gaia : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
> -	Gecko : 950b402b6188bb2f3ce3176e620ed5249719d720
> 
> BR,
> Jinho Lee.

I can reproduce this problem. For the STR, I have to add some comments based on Comment 16.

When I finished the STRs, the device worked well. But If I kept running step 4 and step 5, the computer couldn't surf the Internet when the wifi was disabled. If you checked the status bar, everything worked as expected.

Comment 20

[Vincent Liu[:vliu]]

(In reply to Vincent Liu[:vliu] from comment #19)
> (In reply to Leo from comment #18)
> > Could you please check again in below S/W version?
> > 
> > -	Build ID : 20130421070203
> > -	Gaia : 5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c
> > -	Gecko : 950b402b6188bb2f3ce3176e620ed5249719d720
> > 
> > BR,
> > Jinho Lee.
> 
> I can reproduce this problem. For the STR, I have to add some comments based
> on Comment 16.
> 
> When I finished the STRs, the device worked well. But If I kept running step
> 4 and step 5, the computer couldn't surf the Internet when the wifi was
> disabled. If you checked the status bar, everything worked as expected.

I am sorry for the missing about patch added before testing. With :vchang's patch and Comment 18's S/W version, I can't reproduce this issue anymore.

Comment 21

[Leo]

Dear Mozilla engineer,

the issue is reproduced above S/W version I mentioned.
did you switch between 3G <-> wifi?

as I found, when switching 3G to wifi, the USB tethering always goes off.
Check this point, please.

BR,
Jinho Lee.

Comment 22

[Vincent Chang[:vchang][changyihsin]]

(In reply to Leo from comment #21)
> Dear Mozilla engineer,
> 
> the issue is reproduced above S/W version I mentioned.
> did you switch between 3G <-> wifi?

Yes, I switch between 3G and wifi several times, and I use ping command to verify network connection status.  
 
> as I found, when switching 3G to wifi, the USB tethering always goes off.
> Check this point, please.
I guess it is related to netd command. Can you help to turn on debug log mentioned in comment 17 ?

Comment 23

[xiaokang.chen]

(In reply to Vincent Chang[:vchang] from comment #22)
> (In reply to Leo from comment #21)
> > Dear Mozilla engineer,
> > 
> > the issue is reproduced above S/W version I mentioned.
> > did you switch between 3G <-> wifi?
> 
> Yes, I switch between 3G and wifi several times, and I use ping command to
> verify network connection status.  
>  
> > as I found, when switching 3G to wifi, the USB tethering always goes off.
> > Check this point, please.
> I guess it is related to netd command. Can you help to turn on debug log
> mentioned in comment 17 ?

When I turn on usb tethering, I can't retreive log info by the command "adb logcat"

Comment 24

[Leo]

Dear Mozilla engineer,

Your patch(Patch v1.0) works well in Leo phone.
3G -> Wi-Fi , Wi-Fi -> 3G both are OK.

Thank you.
Jinho Lee.

Comment 25

[Vincent Chang[:vchang][changyihsin]]

> When I turn on usb tethering, I can't retreive log info by the command "adb
> logcat"

You can get the log if you enter "adb logcat" again.

Comment 26

[Vincent Chang[:vchang][changyihsin]]

> Your patch(Patch v1.0) works well in Leo phone.
> 3G -> Wi-Fi , Wi-Fi -> 3G both a

May I know the difference ?

Comment 27

[Leo]

first case is changing interface rmnet0 to wlan0 and second case is wlan0 to rmnet0.

anyway when this patch will be merged into Master git?
I request merging this patch into Mater git for LEO.

Jinho Lee.

Comment 28

[Dave Hylands [:dhylands]]

Hey Vincent,

Do you know if anybody else can review this? I'm not familiar enough with the code to have a good sense of whether its doing the right thing, and I've been working on leo+ bugs, so I haven't had to time to look at the whole thing.

Comment 29

[Vincent Chang[:vchang][changyihsin]]

(In reply to Dave Hylands [:dhylands] from comment #28)
> Hey Vincent,
> 
> Do you know if anybody else can review this? I'm not familiar enough with
> the code to have a good sense of whether its doing the right thing, and I've
> been working on leo+ bugs, so I haven't had to time to look at the whole
> thing.

Ok, let me try to check if I can find someone else to review this. 
Btw, I am going to update the new patch because of Bug 868913.

Comment 30

[Leo]

Dear Vincent,

Merging this patch into git is going on?
Let me know the schedule please.

Thanks,
Jinho Lee.

Comment 31

[David Scravaglieri [:scravag]]

Please ask for a reviewer to land this patch if it is ready.

Comment 32

[Vincent Chang[:vchang][changyihsin]]

I have posted the patch which including the fix to this bug in Bug 868913.