854393 - Update /l10n/ tests to mitigate the "Disconnect Error: Application unexpectedly closed" failure

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Andrei Eftimie]

Related to bug 831297 , but another regression.
Fix should be trivial: update the pre and posthooks to accomodate the new Modal Window that is spawning.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Which new modal window are you talking about?

Comment 2

[Andrei Eftimie]

I think I hurried a bit. Its not a new Modal Dialog, its the same as in bug 831297 (Restart Firefox) but the method it gets invoked has changed.

I have that fixed, but I'm failing later on in another Pref Pane. Still need a bit of work.

Comment 3

[Andrei Eftimie]

Attachment: Patch v1

I have fixed the issue. But in doing so we opened another problem.

When the "Privacy > History > Use custom settings for history > Always use private browsing mode" is checked the checkbox and button on the "Security > Passwords Remember password for sites (checkbox) + Exceptions (button)" are both disabled.

Which would fail with a "Window has been found" error (we click on a disabled button).

To mitigate this issue I moved the Security pane tests before the Privacy pane tests. This solves the problem, but I am not sure it is the best solution.

We might uncheck the "Always use private browsing mode" before moving out of the Privacy pane.

Any input on which solution would be better?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 728990 [details] [diff] [review]
Patch v1

Review of attachment 728990 [details] [diff] [review]:
-----------------------------------------------------------------

This is more a needinfo as a feedback request. Please distinct between both.

As you have already mentioned do not flip the order but reset everything we have modified in the privacy pane. Otherwise we will run into problems all over the place. If that doesn't work at the moment our post handler is not working as expected.

Please also update the summary of the bug so we can identify it beside all the other application disconnected bugs. Thanks.

Comment 5

[Andrei Eftimie]

Attachment: Patch v2

Fixed the issue.
Updated hooks to retain all commands except the one causing the Restart Dialog.

Comment 6

[Andrei Eftimie]

Attachment: Patch v2

Fixed the issue.
Updated hooks to retain all commands except the one causing the Restart Dialog.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 731885 [details] [diff] [review]
Patch v2

Review of attachment 731885 [details] [diff] [review]:
-----------------------------------------------------------------

This tests well for me, but I'd like a second opinion from Henrik, if there's something we should do different.
Also please change the summary of the bug as requested above.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 731885 [details] [diff] [review]
Patch v2

Review of attachment 731885 [details] [diff] [review]:
-----------------------------------------------------------------

If that fixes the problem and let us successfully run the tests, I'm happy with this change. But we should file a follow-up bug to let us disable actions on specific elements. In this case the autostart pb mode. I don' see a reason why we have to click on it. It doesn't change the ui elements in terms of that accesskeys are affected.

Please land on default and aurora at the same time.

Comment 9

[Andreea Matei [:AndreeaMatei]]

Done:
http://hg.mozilla.org/qa/mozmill-tests/rev/fbae63d785f3 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/4cffcdf65d99 (aurora)