854407 - Give the "child process NNNN still alive after shutdown" failure a unique test name

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Ed Morley [:emorley]]

Bug 603147 is a manual star, frequent and annoying.

We should make the failure line:
TEST-UNEXPECTED-FAIL | automation.py | child process %d still alive after shutdown

something like:
TEST-UNEXPECTED-FAIL | zombiecheck | child process %d still alive after shutdown

So that we don't blacklist bug suggestions due to using the (not unique enough) 'automation.py' test name.

Comment 1

[Ed Morley [:emorley]]

Attachment: s/automation.py/zombiecheck/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 728981 [details] [diff] [review]
s/automation.py/zombiecheck/

Review of attachment 728981 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/automation.py.in
@@ +1137,5 @@
>        # Whilst no hung process was found, the run should still display as a failure
>        return True
>  
>      foundZombie = False
> +    self.log.info('INFO | zombiecheck | Reading PID log: %s', processLog)

I really don't like this name, but it is descriptive and I do not have a suitable recommendation for an alternative.

Comment 3

[Ed Morley [:emorley]]

Yeah I couldn't think of anything more appropriate either.

Thanks for the review :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/c039f412b785

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c039f412b785