854457 - Implement talkback support (a11y) in the new tabs tray

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

In other words, implement a11y in TwoWayView.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Implement a11y actions/state and focus handling in TwoWayView

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 730078 [details] [diff] [review]
Implement a11y actions/state and focus handling in TwoWayView


>+            // FIXME: Unfortunately, ViewCompat.setAccessibilityDelegate() doesn't accept
>+            // null delegates.
>+            if (Build.VERSION.SDK_INT >= 14) {
>+                scrap.setAccessibilityDelegate(null);
>+            }
>+
>+
>             if (mRecyclerListener != null) {
>                 mRecyclerListener.onMovedToScrapHeap(scrap);

nit: remove the extra line.

Let's keep a lookout for regressions

Comment 3

[Lucas Rocha (:lucasr)]

Pushed: https://blog.mozilla.org/places/2013/03/27/mozilla-paris-finally-united/

Comment 4

[Eitan Isaacson [:eeejay]]

(In reply to Lucas Rocha (:lucasr) from comment #3)
> Pushed:
> https://blog.mozilla.org/places/2013/03/27/mozilla-paris-finally-united/

LOL. Could have been worse.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> (In reply to Lucas Rocha (:lucasr) from comment #3)
> > Pushed:
> > https://blog.mozilla.org/places/2013/03/27/mozilla-paris-finally-united/
> 
> LOL. Could have been worse.

LOL. Indeed :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/343f9693d283

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/343f9693d283

Comment 7

[Marco Zehe (:MarcoZ)]

Verified working in the 2013-03-28 Nightly build.