854481 - jstypedarray.cpp:2596:35: warning: typedef 'ArrayType' locally defined but not used [-Wunused-local-typedefs]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

GCC 4.8 build warning:
{
js/src/jstypedarray.cpp: In static member function 'static JSBool js::ArrayBufferObject::createTypedArrayFromBuffer(JSContext*, unsigned int, JS::Value*)':

js/src/jstypedarray.cpp:2596:35: warning: typedef 'ArrayType' locally defined but not used [-Wunused-local-typedefs]
}

This typedef exists and is used in other functions, e.g. the one right above this one, but it's indeed unused in createTypedArrayFromBuffer, and was when this code was checked in:
  https://hg.mozilla.org/mozilla-central/rev/5d00c508b09a#l22.492

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50beb409e8d0

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/50beb409e8d0