854514 - B2G mochitest test_settings_blob.html | NS_ERROR_XPC_GS_RETURNED_FAILURE at resource://gre/modules/XPCOMUtils.jsm:202

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Andrew Halberstadt [:ahal]]

See: https://tbpl.mozilla.org/php/getParsedLog.php?id=21065228&tree=Mozilla-Inbound#error0

There is a consistent failure in B2G mochitest-3 which started with https://hg.mozilla.org/integration/mozilla-inbound/rev/5408bf5cf363 (bug 821630). Unfortunately the b2g unittests were hidden so this wasn't caught immediately. This now needs to be added to the list of bugs to be fixed before we can un-hide them again.

Reuben, is this an easy fix?

Comment 1

[Reuben Morais [:reuben]]

This is the same failure that caused the backout in bug 821630 comment 18. I'll try to pinpoint the cause of this error.

Comment 2

[Reuben Morais [:reuben]]

Attachment: Remove observer test

Importing SettingsChangeNotifier.jsm is causing that failure. At first it looked like the way we are importing it in the test was wrong, but test_settings_basics.html does the same and works fine. I think we should either disable this test on B2G emulator builds, or remove it entirely. This patch does the latter.

Comment 3

[Luqman Aden [:Luqman]]

Bug 792594 seems a similar issue

Comment 4

[Reuben Morais [:reuben]]

Attachment: Only import SettingsChangeNotifier.jsm if the mozSettings pref is not enabled

Same solution used by bug 792594. Thanks Luqman.

Comment 5

[Reuben Morais [:reuben]]

Attachment: Only import SettingsChangeNotifier.jsm if the mozSettings pref is not enabled

The permissions part shouldn't be in the if.

Comment 6

[Reuben Morais [:reuben]]

Thanks! I'm leaving this open in case we find a better solution.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6982242c3f0f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6982242c3f0f

Comment 8

[Reuben Morais [:reuben]]

Comment on attachment 729863 [details] [diff] [review]
Only import SettingsChangeNotifier.jsm if the mozSettings pref is not enabled

Clearing this from my "to check in" queue.

Comment 9

[Reuben Morais [:reuben]]

The better solution is coming in bug 862353.