854556 - [Skia] Only hold a ref to the SkCanvas in DrawTargetSkia

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[George Wright (:gw280) (needinfo me!)]

We currently keep track of or own the SkBitmap, SkDevice and SkCanvas. We only really need to own the SkCanvas and let the canvas own everything else.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to George Wright (:gw280) from comment #0)
> We currently keep track of or own the SkBitmap, SkDevice and SkCanvas. We
> only really need to own the SkCanvas and let the canvas own everything else.

We can let SkDevice own the bitmap it looks like, but SkCanvas does not have any way of owning the SkDevice, AFAICT.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Ah, maybe I'm wrong. I guess the device is ref counted, so it should work out.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Only hold SkCanvas in DrawTargetSkia

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a35e0a08ef37

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a35e0a08ef37