If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Skia] Only hold a ref to the SkCanvas in DrawTargetSkia

RESOLVED FIXED in mozilla24

Status

()

Core
Graphics
P1
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: gw280, Assigned: snorp)

Tracking

unspecified
mozilla24
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We currently keep track of or own the SkBitmap, SkDevice and SkCanvas. We only really need to own the SkCanvas and let the canvas own everything else.
Blocks: 848482
(In reply to George Wright (:gw280) from comment #0)
> We currently keep track of or own the SkBitmap, SkDevice and SkCanvas. We
> only really need to own the SkCanvas and let the canvas own everything else.

We can let SkDevice own the bitmap it looks like, but SkCanvas does not have any way of owning the SkDevice, AFAICT.
Ah, maybe I'm wrong. I guess the device is ref counted, so it should work out.
Priority: -- → P1
Blocks: 858237
Depends on: 874560
No longer depends on: 874560
Created attachment 754825 [details] [diff] [review]
Only hold SkCanvas in DrawTargetSkia
Assignee: gwright → snorp
Status: NEW → ASSIGNED
Attachment #754825 - Flags: review?(matt.woodrow)
Attachment #754825 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a35e0a08ef37
https://hg.mozilla.org/mozilla-central/rev/a35e0a08ef37
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.