Closed Bug 854556 Opened 7 years ago Closed 6 years ago

[Skia] Only hold a ref to the SkCanvas in DrawTargetSkia

Categories

(Core :: Graphics, defect, P1)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: gw280, Assigned: snorp)

References

Details

Attachments

(1 file)

We currently keep track of or own the SkBitmap, SkDevice and SkCanvas. We only really need to own the SkCanvas and let the canvas own everything else.
(In reply to George Wright (:gw280) from comment #0)
> We currently keep track of or own the SkBitmap, SkDevice and SkCanvas. We
> only really need to own the SkCanvas and let the canvas own everything else.

We can let SkDevice own the bitmap it looks like, but SkCanvas does not have any way of owning the SkDevice, AFAICT.
Ah, maybe I'm wrong. I guess the device is ref counted, so it should work out.
Priority: -- → P1
Depends on: 874560
No longer depends on: 874560
Assignee: gwright → snorp
Status: NEW → ASSIGNED
Attachment #754825 - Flags: review?(matt.woodrow)
Attachment #754825 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/a35e0a08ef37
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.