SettingsManager's init method should return a non-XPCOM object

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: ggp, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
The object returned from init() in an implementation of nsIDOMGlobalPropertyInitializer should be a different object implementing only the API to be exposed, and nothing more.

If the XPCOM object itself is returned -- and note that returning nothing from init() also causes the XPCOM object to be used --  it is possible to QI into that object and, for example, call init() again, which might not be safe.
Component: General → DOM: Device Interfaces
Hardware: x86 → All
Version: unspecified → Trunk
Fixed by bug 889503.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.