854629 - Don't declare nsISupports in SVG element classes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Part 0: Not sure where to put this

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Part 1: Remove nsIDOMSVGUnitTypes

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: Part 2: Remove nsISupports when there is only one base class

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Want to also remove hasXPConnectImpls from the SVGElement descriptor in Bindings.conf?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 729304 [details] [diff] [review]
Part 2: Remove nsISupports when there is only one base class

Review of attachment 729304 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 5

[David Zbarsky (:dzbarsky)]

(In reply to :Ms2ger from comment #3)
> Want to also remove hasXPConnectImpls from the SVGElement descriptor in
> Bindings.conf?

Good catch

Comment 6

[Boris Zbarsky [:bzbarsky]]

For part 1, you can nix the svgelement include in that file too, right?

Comment 7

[Boris Zbarsky [:bzbarsky]]

I meant part 0.  ;)

Comment 8

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28feb89ac666
https://hg.mozilla.org/integration/mozilla-inbound/rev/833ddc983ff5
https://hg.mozilla.org/integration/mozilla-inbound/rev/8539f16b6763

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/28feb89ac666
https://hg.mozilla.org/mozilla-central/rev/833ddc983ff5
https://hg.mozilla.org/mozilla-central/rev/8539f16b6763