Closed
Bug 854629
Opened 8 years ago
Closed 8 years ago
Don't declare nsISupports in SVG element classes
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(3 files)
1.04 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
13.56 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
105.69 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #729301 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #729302 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #729304 -
Flags: review?(Ms2ger)
Updated•8 years ago
|
Attachment #729301 -
Flags: review?(Ms2ger) → review+
Comment 3•8 years ago
|
||
Want to also remove hasXPConnectImpls from the SVGElement descriptor in Bindings.conf?
Updated•8 years ago
|
Attachment #729302 -
Flags: review?(Ms2ger) → review+
Comment 4•8 years ago
|
||
Comment on attachment 729304 [details] [diff] [review] Part 2: Remove nsISupports when there is only one base class Review of attachment 729304 [details] [diff] [review]: ----------------------------------------------------------------- \o/
Attachment #729304 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to :Ms2ger from comment #3) > Want to also remove hasXPConnectImpls from the SVGElement descriptor in > Bindings.conf? Good catch
![]() |
||
Comment 6•8 years ago
|
||
For part 1, you can nix the svgelement include in that file too, right?
![]() |
||
Comment 7•8 years ago
|
||
I meant part 0. ;)
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/28feb89ac666 https://hg.mozilla.org/integration/mozilla-inbound/rev/833ddc983ff5 https://hg.mozilla.org/integration/mozilla-inbound/rev/8539f16b6763
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/28feb89ac666 https://hg.mozilla.org/mozilla-central/rev/833ddc983ff5 https://hg.mozilla.org/mozilla-central/rev/8539f16b6763
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•