854813 - Linked contacts without name but with e-mail are rendered wrong

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Cristian Rodriguez (:crdlc)]

STR:

1) I have a contact with just email and photo defined ([e-mail])
2) I gonna link this one to my friend "Kevin Maicon" in Facebook
3) The first time, the contact is displayed correctly on the list showing "Kevin Maicon" and his picture
4) Close the contacts app
5) Open the contacts app
6) You can view the contact item with the name "[e-mail] [e-mail]". The name will be the email duplicated

Comment 1

[Cristian Rodriguez (:crdlc)]

It is reproducible on v1.0.1, v1-train and master

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 3

[Jose Manuel Cantera]

After landing bug 852036, this patch will also need to be tef+, as otherwise linked contacts could not be searchable and even they could wrongly placed on the build, so nominating it. I can clarify more if needed

Comment 4

[Jose Manuel Cantera]

(In reply to Jose M. Cantera from comment #3)
> After landing bug 852036, this patch will also need to be tef+, as otherwise
> linked contacts could not be searchable and even they could wrongly placed
> on the build, so nominating it. I can clarify more if needed

erratum

After landing bug 852036, this patch will also need to be tef+, as otherwise
linked contacts could not be searchable and even they could wrongly be placed
on the list, so nominating it. I can clarify more if needed

Comment 6

[Daniel Coloma:dcoloma]

based on screenshots in bug 855353 I think we need to block

Comment 7

[Cristian Rodriguez (:crdlc)]

I have to support updates on given and family names on FB, after that maybe we could land this one

Comment 8

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/4978fc82b2877394af5bc43a377cfafff99b4e06

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 4978fc82b2877394af5bc43a377cfafff99b4e06
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 10

[Cristian Rodriguez (:crdlc)]

On v1-train

https://github.com/mozilla-b2g/gaia/commit/06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75

Comment 11

[Cristian Rodriguez (:crdlc)]

On v1.0.1

https://github.com/mozilla-b2g/gaia/commit/cb5375ccbdf5b85893a115e922f5405b1cfcbcb3

Comment 12

[amiller]

issue is NOT reproducible on both V1.0.1 and V1.1.0
- Name field was not the duplicated by auto populated email address in the first name field.  

tested on Unagi running the following builds:
V1.0.1
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ccec751a468e
Gaia   ee0bef61c0a25c806dd1eec5a4e047bc418a5f73
Build  2013-04-02-070202

V1.1.0
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/68c8a883cfc0
Gaia   1c38c91bb16f2bf0d5066c4787d2249463f61bb3
Build  2013-04-02-070204Maps 

Photo is populated with the photo created on the device side. First name and all other fields are populated with the facebook information that has been linked.