854907 - Raise the threshold for suppressing the weekly War on Orange summary email when we think the OF is inaccurate

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Ed Morley [:emorley]]

Bug 827856 made it that if the OF was calculated to be zero (due to a long-standing bug), we suppress the normal email & instead contact admins.

Whilst this worked fine this week, last week we had a reported OF of 0.1, which was clearly wrong, but (obviously) wasn't suppressed.

Whilst the ideal solution would be to fix the root cause of the incorrect OF; given that the OF is currently 7.xx we should just raise the threshold for now, to catch more broken cases in the meantime.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 729569 [details] [diff] [review]
Patch v1

Review of attachment 729569 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: woo_mailer.py
@@ +224,5 @@
>                                                       stats['orangefactorstr'],
>                                                       change)
>  
> +    if stats['orangecount'] <= 2 and not options.test_mode:
> +        error_msg = 'This week\'s orange count is less than 2! Something must have broken :-('

Tecccccchnically less than or equal to 2. :)

Comment 3

[Ed Morley [:emorley]]

Good point, I've adjusted the operator :-)

https://hg.mozilla.org/automation/orangefactor/rev/e72486078cd8

Comment 4

[Mark Côté [:mcote]]

Deployed to flyingtanks.  Thanks!

Comment 5

[Ed Morley [:emorley]]

Thank you :-0