Closed Bug 855012 Opened 8 years ago Closed 8 years ago

local_debug_info_symbolizer.cc,h and shim_mac_dump_syms.mm,h have no license information (& probably need MPL boilerplate)

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: jseward)

References

Details

Attachments

(1 file)

The files local_debug_info_symbolizer.cc, local_debug_info_symbolizer.h, shim_mac_dump_syms.h, and shim_mac_dump_syms.mm were checked in without any license block, in this changeset:
  https://hg.mozilla.org/mozilla-central/rev/cc45fdc389df#l11.1

I'm assuming this was just an oversight and they should all be MPL licensed like the other new files in that commit (as long as they weren't taken from another project, in which case I think we'd need to include the other project's license header, though IANAL).

jseward, can you comment on whether these should just have an MPL block?
That's just a oversight. It's mozilla code. I saw it but forgot to point it out in the review.
I wrote shim_mac_dump_syms.{mm,h} so they're MPLable.
local_debug_info_symbolizer.{cc,h} came from Ted, and I'm not
clear if they are new or derivatives of existing bits of
breakpad.  Ted?
They're original code I wrote, so MPL is fine. Sorry about that.
Attached patch PatchSplinter Review
Attachment #730160 - Flags: review?(dholbert)
Comment on attachment 730160 [details] [diff] [review]
Patch

Thanks!
Attachment #730160 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/52cd656def30
Assignee: nobody → jseward
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.