855012 - local_debug_info_symbolizer.cc,h and shim_mac_dump_syms.mm,h have no license information (& probably need MPL boilerplate)

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Daniel Holbert [:dholbert]]

The files local_debug_info_symbolizer.cc, local_debug_info_symbolizer.h, shim_mac_dump_syms.h, and shim_mac_dump_syms.mm were checked in without any license block, in this changeset:
  https://hg.mozilla.org/mozilla-central/rev/cc45fdc389df#l11.1

I'm assuming this was just an oversight and they should all be MPL licensed like the other new files in that commit (as long as they weren't taken from another project, in which case I think we'd need to include the other project's license header, though IANAL).

jseward, can you comment on whether these should just have an MPL block?

Comment 1

[Benoit Girard (:BenWa)]

That's just a oversight. It's mozilla code. I saw it but forgot to point it out in the review.

Comment 2

[Julian Seward [:jseward]]

I wrote shim_mac_dump_syms.{mm,h} so they're MPLable.
local_debug_info_symbolizer.{cc,h} came from Ted, and I'm not
clear if they are new or derivatives of existing bits of
breakpad.  Ted?

Comment 3

[(not currently active) Ted Mielczarek]

They're original code I wrote, so MPL is fine. Sorry about that.

Comment 4

[Julian Seward [:jseward]]

Attachment: Patch

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 730160 [details] [diff] [review]
Patch

Thanks!

Comment 6

[Julian Seward [:jseward]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/52cd656def30

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/52cd656def30