855072 - t/012throwables.t should allow for error tags to be contained by single quotes and not just double

Status: NEW

(Bugzilla :: Testing Suite, enhancement)

Description

[David Lawrence [:dkl]]

Currently t/012throwables.t will find error tag names in templates that are surrounded by double quotes but not single quotes. Example:

extensions/Example/template/en/default/hook/global/user-error-errors.html.tmpl

PASS:
[% IF error == "example_my_error" %]

FAIL:
[% IF error == 'example_my_error' %]

Both are considered valid by TT2 and so the test should not fail.

Patch coming.
dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to t/012throwables.t to allow for single quotes (v1)

Comment 2

[Frédéric Buclin]

You have to make sure you balance " with another ", and a ' with another '.

["']...["'] doesn't enforce that.

Comment 3

[Marc Schumann [:Wurblzap]]

(In reply to Frédéric Buclin from comment #2)
> You have to make sure you balance " with another ", and a ' with another '.
> 
> ["']...["'] doesn't enforce that.


Wouldn't this result in a syntax error anyway, if they weren't balanced?

Comment 4

[David Lawrence [:dkl]]

(In reply to Marc Schumann [:Wurblzap] from comment #3)
> (In reply to Frédéric Buclin from comment #2)
> > You have to make sure you balance " with another ", and a ' with another '.
> > 
> > ["']...["'] doesn't enforce that.
> 
> 
> Wouldn't this result in a syntax error anyway, if they weren't balanced?

True. Wouldn't t/004template.t catch those before t/012throwables.t?

dkl

Comment 5

[Frédéric Buclin]

"What's wrong with that?" is correctly balanced, but your regexp would catch "What' only.

Comment 6

[David Lawrence [:dkl]]

Sorry wrong bug id.

Comment 7

[David Lawrence [:dkl]]

Attachment: Patch to t/012throwables.t to allow for single quotes (v2)

Can't think of a reason anyone should ever use ' or " in an error tag name but suppose it could happen. This patch works around that issue by using a negative look around.

dkl

Comment 8

[Frédéric Buclin]

Comment on attachment 730698 [details] [diff] [review]
Patch to t/012throwables.t to allow for single quotes (v2)

>+        if ($line =~ /\[%\s[A-Z]+\s*error\s*==\s*["']+((?!["']+\s*%\]]).+)["']+\s*%\]/) {
>             my $errtag = $1;

That's way too complicated, and ["']+ is not correct here. Simply use \1 to catch exactly what has been caught initially:

(["'])(\s+)\1

Here \1 will be replaced by what has been caught by ["'], so that it remains correctly balanced. This also means that $errtag must now look at $2.

Comment 9

[Frédéric Buclin]

> (["'])(\s+)\1

Err... I meant (["'])(.+)\1 of course.