855112 - OS.File.read fails with a "reference to undefined property options.bytes" JS Error

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Florian Quèze [:florian]]

I tried using OS.File.read on the main thread in a JS module.

It failed with this error:
JS Component Loader: ERROR resource://gre/modules/osfile/osfile_async_front.jsm:106
                     Error: Queue is empty

I enabled DEBUG in osfile_async_front.jsm and got this JS error:
OS Controller Received uncaught error from worker "reference to undefined property options.bytes" reference to undefined property options.bytes

I poked a bit at the code, http://hg.mozilla.org/mozilla-central/annotate/c9bf19d37fe0/toolkit/components/osfile/osfile_shared_front.jsm#l57 seems to be a Number, but at http://hg.mozilla.org/mozilla-central/annotate/c9bf19d37fe0/toolkit/components/osfile/osfile_shared_front.jsm#l85 an object seems expected.

I tried changing line 57 to:
    let size = this.readTo(buffer, {bytes: bytes});
and my code worked, but that's just a random guess.

I tried this with Mozilla 19, so the bug may be already fixed, but the code I edited is still present on mozilla-central, so I would rather file a dup then let this go unreported.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Your fix is very likely correct. Could you please submit a patch?

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

Patch as suggested in comment 0.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 730061 [details] [diff] [review]
Patch

Review of attachment 730061 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if this passes tests
Thanks for the bugfix!

Comment 4

[Florian Quèze [:florian]]

(In reply to David Rajchenbach Teller [:Yoric] from comment #3)

> r=me if this passes tests

Tests look green to me on try: https://tbpl.mozilla.org/?tree=Try&rev=c2ea9edc460b


https://hg.mozilla.org/integration/mozilla-inbound/rev/6b3122df808d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6b3122df808d