855173 - jsshell package needs nss3.dll due to MOZ_FOLD_LIBS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

$ dumpbin -dependents js.exe
Microsoft (R) COFF/PE Dumper Version 10.00.40219.01
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file js.exe

File Type: EXECUTABLE IMAGE

  Image has the following dependencies:

    nss3.dll
    KERNEL32.dll
    WINMM.dll
    PSAPI.DLL
    MSVCR100.dll
    mozglue.dll

  Summary

       2C000 .data
       5B000 .rdata
       1E000 .reloc
      274000 .text

But,

$ unzip -l ~/Downloads/jsshell-win32.zip
Archive:  c:/Users/mkato/Downloads/jsshell-win32.zip
  Length     Date   Time    Name
 --------    ----   ----    ----
  3180544  13/03/26 20:52   js.exe
   126464  13/03/26 20:42   mozglue.dll
   770384  10/03/19 01:15   msvcr100.dll
 --------                   -------
  4077392                   3 files

Comment 1

[Makoto Kato [:m_kato]]

Test package is ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-03-26-03-09-41-mozilla-central/jsshell-win32.zip

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 730001 [details] [diff] [review]
fix

Review of attachment 730001 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +69,5 @@
>    $(DIST)/bin/js$(BIN_SUFFIX) \
>    $(DIST)/bin/$(DLL_PREFIX)mozglue$(DLL_SUFFIX) \
>    $(NULL)
>  ifndef MOZ_NATIVE_NSPR
> +ifdef _MSC_VER

In fact, you can remove the ifdef, since all the things enclosed are testing for _MSC_VER value anyways.

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34a026a9bce0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34a026a9bce0