Closed
Bug 855192
Opened 11 years ago
Closed 11 years ago
SpecialPowers.MockPermissionPrompt doesn't work on B2G builds
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: dchanm+bugzilla, Assigned: dchanm+bugzilla)
Details
Attachments
(1 file)
|
2.02 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
This is likely a result of bug 798491 which is enabled on b2g builds. The fix is to change the "var" to "this" at http://mxr.mozilla.org/mozilla-central/source/testing/specialpowers/content/MockPermissionPrompt.jsm#33 I'll attach a testcase and patch tomorrow.
|
Assignee | |
Comment 1•11 years ago
|
||
try push here https://tbpl.mozilla.org/?tree=Try&rev=8447a2a7b7a9 The change should only affect b2g builds, but I can run a full try run if needed too.
Attachment #730316 -
Flags: review?(jgriffin)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 730316 [details] [diff] [review] change var to this Looks good.
Attachment #730316 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/76d14e65da84
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/76d14e65da84
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•