Closed Bug 855192 Opened 10 years ago Closed 10 years ago

SpecialPowers.MockPermissionPrompt doesn't work on B2G builds

Categories

(Testing :: Mochitest, defect)

Product:
Testing
Component:
Mochitest
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: dchanm+bugzilla, Assigned: dchanm+bugzilla)

Details

Attachments

(1 file)

change var to this
2.02 KB, patch
jgriffin
: review+
Details | Diff | Splinter Review 
This is likely a result of bug 798491 which is enabled on b2g builds. The fix is to change the "var" to "this" at
http://mxr.mozilla.org/mozilla-central/source/testing/specialpowers/content/MockPermissionPrompt.jsm#33

I'll attach a testcase and patch tomorrow.
try push here
https://tbpl.mozilla.org/?tree=Try&rev=8447a2a7b7a9

The change should only affect b2g builds, but I can run a full try run if needed too.
Attachment #730316 - Flags: review?(jgriffin)
Comment on attachment 730316 [details] [diff] [review]
change var to this

Looks good.
Attachment #730316 - Flags: review?(jgriffin) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76d14e65da84
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.