Closed
Bug 855227
Opened 13 years ago
Closed 13 years ago
Deprecate --enable-chrome-format=symlink
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.96 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I added an extra deprecation warning for 'symlink', just to be extra helpful to the quite a few people I know of that are using it. Should I do the same for 'both'? I don't know of anyone using it to be honest.
Attachment #730043 -
Flags: review?(mh+mozilla)
Comment 1•13 years ago
|
||
Comment on attachment 730043 [details] [diff] [review]
Patch v1
Review of attachment 730043 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +7782,1 @@
> Select FORMAT of chrome files (default=jar)],
While here, can you change this to something like "Select FORMAT of chrome files during packaging"
@@ +7786,5 @@
> MOZ_CHROME_FILE_FORMAT=jar
> fi
>
> +if test "$MOZ_CHROME_FILE_FORMAT" = "symlink"; then
> + AC_MSG_ERROR([--enable-chrome-format=symlink has been deprecated. It is now used by default in platforms that support it])
in $DIST/bin on platforms that support it.
Attachment #730043 -
Flags: review?(mh+mozilla) → review+
Updated•13 years ago
|
Blocks: new-packager
| Assignee | ||
Comment 2•13 years ago
|
||
Addressed previous comments and also made packager.py treat 'symlink' the same as 'jar', so it can actually produce a package.
Attachment #730043 -
Attachment is obsolete: true
Attachment #730062 -
Flags: review?(mh+mozilla)
Comment 3•13 years ago
|
||
Comment on attachment 730062 [details] [diff] [review]
Patch v2
Review of attachment 730062 [details] [diff] [review]:
-----------------------------------------------------------------
r=me without the packager.py change.
::: toolkit/mozapps/installer/packager.py
@@ +262,5 @@
>
> copier = FileCopier()
> if args.format == 'flat':
> formatter = FlatFormatter(copier)
> + elif args.format == 'jar' or args.format == 'symlink':
I'd rather not touch packager.py here.
Attachment #730062 -
Flags: review?(mh+mozilla) → review+
| Assignee | ||
Comment 4•13 years ago
|
||
You are right, the packager.py change is not needed. That's what I get for working in two computers at the same time.
| Assignee | ||
Comment 5•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla22
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•