855227 - Deprecate --enable-chrome-format=symlink

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

I added an extra deprecation warning for 'symlink', just to be extra helpful to the quite a few people I know of that are using it. Should I do the same for 'both'? I don't know of anyone using it to be honest.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 730043 [details] [diff] [review]
Patch v1

Review of attachment 730043 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +7782,1 @@
>                            Select FORMAT of chrome files (default=jar)],

While here, can you change this to something like "Select FORMAT of chrome files during packaging"

@@ +7786,5 @@
>      MOZ_CHROME_FILE_FORMAT=jar
>  fi
>  
> +if test "$MOZ_CHROME_FILE_FORMAT" = "symlink"; then
> +    AC_MSG_ERROR([--enable-chrome-format=symlink has been deprecated. It is now used by default in platforms that support it])

in $DIST/bin on platforms that support it.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

Addressed previous comments and also made packager.py treat 'symlink' the same as 'jar', so it can actually produce a package.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 730062 [details] [diff] [review]
Patch v2

Review of attachment 730062 [details] [diff] [review]:
-----------------------------------------------------------------

r=me without the packager.py change.

::: toolkit/mozapps/installer/packager.py
@@ +262,5 @@
>  
>      copier = FileCopier()
>      if args.format == 'flat':
>          formatter = FlatFormatter(copier)
> +    elif args.format == 'jar' or args.format == 'symlink':

I'd rather not touch packager.py here.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

You are right, the packager.py change is not needed. That's what I get for working in two computers at the same time.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/c88ccb89284f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c88ccb89284f