855229 - Adjust focus-rect on tabs for Australis

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

Attachment: Current focus rect on a box outside the curve (from :jaws)

The focus rect is currently outside the curve which looks unusual.  Perhaps it should be inside the curve, maybe around the label? The top doesn't seem to be shown for me on Aero. This comes from the following on Windows and Linux (see URL):

  /* tabbrowser-tab focus ring */
  .tabbrowser-tab:focus > .tab-stack {
    outline: 1px dotted;
  }

Comment 1

[Matthew N. [:MattN]]

Attachment: Proposal to move current outline to .tab-label (screenshot)

This is what it looks like with the same outline: 1px dotted; applied to .tab-label.

Stephen, what do you think? If you want to test a variation you can use DOMi to set the :focus pseudo-class on an element from the context menu in the DOM Nodes pane.

Comment 2

[Stephen Horlander [:shorlander]]

Comment on attachment 730051 [details]
Proposal to move current outline to .tab-label (screenshot)

Looks better than surrounding the full tab including all the empty space.

Comment 3

[Matthew N. [:MattN]]

Attachment: v.1 Move focus rect to .tab-label

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 738397 [details] [diff] [review]
v.1 Move focus rect to .tab-label

Review of attachment 738397 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, LGTM - much better on OSX. Thanks!

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/a84599943699