Closed Bug 855275 Opened 12 years ago Closed 11 years ago

Intermittent toolkit/components/passwordmgr/test/test_notifications_popup.html | Test timed out.

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Platform:
All
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: RyanVM, Assigned: MattN)

References

Details

(Keywords: intermittent-failure)

https://tbpl.mozilla.org/php/getParsedLog.php?id=21144448&tree=Mozilla-Inbound WINNT 6.2 mozilla-inbound opt test mochitest-5 on 2013-03-26 22:58:16 PDT for push eb3e5d23f987 slave: t-w864-ix-070 23:05:08 INFO - 165724 INFO TEST-START | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html 23:05:08 INFO - 165725 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Access Ci 23:05:08 INFO - 165726 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Access Cc 23:05:08 INFO - 165727 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Access pwmgr 23:05:09 INFO - 165728 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Got popupNotifications 23:05:09 INFO - 165729 INFO TEST-INFO | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | must wait for load 23:05:09 INFO - 165730 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Starting test #1 23:05:09 INFO - 165731 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Looking for password-save popup notification 23:05:09 INFO - 165732 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | got notification popup 23:05:09 INFO - 165733 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Should not have any logins yet 23:05:09 INFO - 165734 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Looking for action at index 0 23:05:09 INFO - 165735 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | at least one notification displayed 23:05:09 INFO - 165736 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | 1 notifications 23:05:09 INFO - 165737 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Triggering main action 23:05:09 INFO - 165738 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Starting test #2 23:05:10 INFO - 165739 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Should only have 1 login 23:05:10 INFO - 165740 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | 1 - Check times used on new entry 23:05:10 INFO - 165741 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Looking for password-change popup notification 23:05:10 INFO - 165742 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | got notification popup 23:05:10 INFO - 165743 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Looking for action at index 0 23:05:10 INFO - 165744 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | at least one notification displayed 23:05:10 INFO - 165745 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | 1 notifications 23:05:10 INFO - 165746 INFO TEST-PASS | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Triggering main action 23:10:09 INFO - 165747 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | Test timed out. 23:10:09 INFO - args: ['C:\\slave\\test\\build\\tests\\bin\\screenshot.exe', 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\mozilla-test-fail__ujxlo'] 23:10:09 INFO - SCREENSHOT: <see log> 23:10:10 INFO - 165748 INFO TEST-END | /tests/toolkit/components/passwordmgr/test/test_notifications_popup.html | finished in 301220ms
OS: All → Windows 8
I have also been getting this timeout for test_notifications_popup a lot. https://tbpl.mozilla.org/?tree=Try&rev=ddd93ec4f98f Locally, it works fine. But when I do a refresh, it fails with aPopup not defined. Then when I do a second refresh and it works. It works on every other refresh (very odd).
The screenshot of comment 0 doesn't show the browser window so I assume it is minimized. This may be unrelated to the test so I'm going to disregard this. Comment 1 may be a legit failure but I don't know the cause yet It's hard to say if comment 2 is related since there is only one prior failure and it's failing in a different spot of the test. I suspect this is related to the fact that the mixed content doorhanger is also showing in the location bar. The password manager notification shouldn't be dismissed in the screenshot so I think there is a popup notification bug that is causing this. Isn't this what bug 854740 is about though? This try push doesn't seem to include that patch. Let's move this discussion back to bug 854740 though. It would be useful to diff the output from the run before and after a refresh.
(In reply to Matthew N. [:MattN] from comment #3) > The screenshot of comment 0 doesn't show the browser window so I assume it > is minimized. This may be unrelated to the test so I'm going to disregard > this. > > Comment 1 may be a legit failure but I don't know the cause yet > > It's hard to say if comment 2 is related since there is only one prior > failure and it's failing in a different spot of the test. I suspect this is > related to the fact that the mixed content doorhanger is also showing in the > location bar. The password manager notification shouldn't be dismissed in > the screenshot so I think there is a popup notification bug that is causing > this. Isn't this what bug 854740 is about though? This try push doesn't > seem to include that patch. Let's move this discussion back to bug 854740 > though. It would be useful to diff the output from the run before and after > a refresh. Hey Matt, Thanks for your comments! Sure, we can continue the discussion on bug 854740, though I'm not sure whether or not that bug will fix the test_notifications_popup test. None of the patches that Gavin has presented fix the test_notifications_popup timeout issue. The timeout issue occurs when mixed active content blocking is turned on. The refresh issue exists without the patch to turned mixed active content blocking on (hence it exists on mozilla-central today). Every other refresh works. So I don't think that has anything to do with mixed content. I'll see if I can catch you later today and we can discuss in person, and sort out if I should file a new bug, discuss this here, or in bug 854740. In the meantime, I will keep digging and see if I come up with anything. What perplexes me the most is that there really is no mixed content on test_notifications_popup. The page is http (not https).
Blocks: 834836
I was digging into this some more today as I was hitting it reliably on my local mochitest-plain run. There is a bug where popupWin.close() is closing the whole window rather than just the tab which aligns with the screenshot I mentioned in comment 3. I'll file a bug later. I have a testcase at http://people.mozilla.com/~mnoorenberghe/tmp/window_close/ but I haven't figured out the conditions for it to be reproducible because it doesn't close the window on a new profile for me.
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
This hasn't failed for 7 months even though the test is still enabled.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.