855279 - Pass in symbols_path to marionette unittests and set minidump_stackwalk

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Marionette should check for crashes at the end of a test run (or timeout).

Comment 1

[Andrew Halberstadt [:ahal]]

I realized that all the gecko work for this was done in bug 843296 and bug 849270, so morphing this bug to take care of the mozharness side.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - pass in --symbols-path and minidump_stackwalk to marionette unittests

I can't land this until both the last patch from bug 843296 and bug 849270 have landed everywhere that marionette is running, including b2g18-v1.0.1 etc..

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 730279 [details] [diff] [review]
Patch 1.0 - pass in --symbols-path and minidump_stackwalk to marionette unittests

The thing I don't like about this patch is that it makes run-marionette require you to have run download-and-extract in the same run (you have to install minidump stackwalk in order to have self.minidump_stackwalk_path set, even if you installed it manually or in a previous run).  We have other inter-action runtime dependencies, but I'd like to eliminate them.

Could you either split out the path determination from the install, or make something like a query_minidump_stackwalk_path() that installs if it's not there, but otherwise returns the path without installing?

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 2.0 - split out path finding step from install step

Addresses previous comment. I also switched the b2g emulator unittest script to use the new method.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 730340 [details] [diff] [review]
Patch 2.0 - split out path finding step from install step

Thanks!

Comment 6

[Andrew Halberstadt [:ahal]]

I added a dummy --symbols-path argument to the b2g18_v1_0_1 branch, but then realized it'll also need to be added to beta and aurora (release doesn't run Mn tests). Sigh.

Comment 7

[Andrew Halberstadt [:ahal]]

I pushed the dummy patch to aurora and beta too. Pushed this patch to ash-mozharness and awaiting the results:
https://tbpl.mozilla.org/?showall=1&tree=Ash&rev=b0433d7d9e26

Comment 8

[Andrew Halberstadt [:ahal]]

Patch works on ash. I found an unrelated issue, but it's marionette related so checked this one in:
https://hg.mozilla.org/build/mozharness/rev/517abd76cac9