855365 - Focusing tabs in the awesome screen doesn't work properly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Remove focus

See http://people.mozilla.com/~kgupta/tmp/awesome.png

Also if we get the visual kinks worked out, each of the tabs will need separate "selected" and "focused" states, so that you can switch focus to a different tab without selecting it, and then press the enter/action button to select it. Upon selection, the viewpager below should update to reflect the desired tab content.

I have a patch that removes focusability from the tab widget entirely, which also fixes this problem by preventing it from happening in the first place. It's still possible to switch tabs by going left/right with focus in the viewpager, so I think this is an acceptable fallback if we can't get it working perfectly.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 730235 [details] [diff] [review]
Remove focus

I'd like to land this for now. It can be backed out/undone once we have proper focus support for the tab widget.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e15f135411f9

Marking as leave open so that we can continue working on proper focus support in this bug.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e15f135411f9