855424 - Clicking on Insert A Link Button Performs Action

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect)

Description

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130307023931

Steps to reproduce:

Open a new message to send, type into message field and clicked on "insert A Link" button field.


Actual results:

Message was sent when "Insert A Link" button was clicked. 


Expected results:

Insert a link pop up should've appeared and not send a message.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

This bug is referring to private messaging:
https://support.mozilla.org/en-US/messages/new

Clicking on the "Insert a link" icon tries to submit the form.

Looking at the console, I see a js error:
[15:48:54.960] TypeError: h.find(...).autocomplete is not a function @ https://support.cdn.mozilla.net/media/js/messages-min.js?build=5382aa9:1

Should be 1pt to fix that.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

This is actually happening on all pages that have the wiki markup editor. Or at least I tested /kb/new and private messaging.

I think this might be related to not lazy loading jquery.ui anymore.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Working on this now.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

In a PR:
https://github.com/mozilla/kitsune/pull/1230

Comment 5

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Great to hear! This affects contributors forums and kb edits but not the support forum.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

on master:
https://github.com/mozilla/kitsune/commit/1db693d1e20ac815fb87a8b817047ab5dfcfc739

Comment 7

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #6)
> on master:
> https://github.com/mozilla/kitsune/commit/
> 1db693d1e20ac815fb87a8b817047ab5dfcfc739

Is "Contributors Forums" on there too?

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Feer56 (Andrew T.) from comment #7)
> Is "Contributors Forums" on there too?

Now it is :) => https://github.com/mozilla/kitsune/commit/c9ff449f5a2d27f853ba63d49f9a9da5542711c2

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now. Nice find!