Last Comment Bug 855455 - enable @supports rule in all builds
: enable @supports rule in all builds
: dev-doc-complete
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
P3 normal (vote)
: mozilla22
Assigned To: David Baron :dbaron: ⌚️UTC-8
: Jet Villegas (:jet)
Depends on:
Blocks: 864005
  Show dependency treegraph
Reported: 2013-03-27 13:49 PDT by David Baron :dbaron: ⌚️UTC-8
Modified: 2014-05-21 15:48 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Turn on @supports in release builds. (990 bytes, patch)
2013-03-27 13:50 PDT, David Baron :dbaron: ⌚️UTC-8
cam: review+
Details | Diff | Splinter Review

Description User image David Baron :dbaron: ⌚️UTC-8 2013-03-27 13:49:53 PDT
Currently @supports rules are enabled for nightly/aurora versions but not for beta/release versions.  Given that the spec is going to CR very soon (and should be by the time current nightly gets to beta), we should enable it for all builds so that we ship it.

I don't see any known issues that should block us from doing this.  (I don't see any valid issues remaining in bug 780060 or bug 816045.)

But I probably ought to check the current test suite submissions.
Comment 1 User image David Baron :dbaron: ⌚️UTC-8 2013-03-27 13:50:51 PDT
Created attachment 730335 [details] [diff] [review]
Turn on @supports in release builds.
Comment 2 User image Cameron McCormack (:heycam) (away 25 Feb–5 Mar) 2013-03-28 23:09:51 PDT
Comment on attachment 730335 [details] [diff] [review]
Turn on @supports in release builds.

r=me if you're happy with how we fare on any @supports tests we haven't yet imported from the official test suite.
Comment 3 User image David Baron :dbaron: ⌚️UTC-8 2013-03-31 00:52:21 PDT

I still need to go through the tests, though.
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2013-04-01 11:01:14 PDT
Comment 5 User image sjw 2013-05-16 12:18:00 PDT
Could someone update the realese notes?
Comment 6 User image David Baron :dbaron: ⌚️UTC-8 2013-05-16 14:44:52 PDT
I don't think this belongs in the release notes, but it does belong in developer documentation.
Comment 7 User image David Baron :dbaron: ⌚️UTC-8 2013-05-31 02:41:39 PDT
In Opera's tests, we fail at-supports-014, which is incorrect as described here (with patch):

and we fail 4 items in contributors/opera/submitted/css3-conditional/js/001.html .  I again think the test is invalid, as described here:

Note You need to log in before you can comment on or make changes to this bug.