855520 - "No element selected" in the inspector sidebar could use some margins

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

I think that's pretty ugly.

Debugger (and upcoming network monitor) sidebars use am inherited (-moz-box?) font family and size with 4px margins and GrayText.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Patch v1

This gives the "No element selected" message the same padding as the rules that appear when something is selected.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 734431 [details] [diff] [review]
Patch v1

Review of attachment 734431 [details] [diff] [review]:
-----------------------------------------------------------------

You should also use a
>  font: message-box;
and
>  color: GrayText;
for the #noResults element specifically, since that's the style used by every other pane across the developer tools for signaling that "There's nothing here yet".

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 734431 [details] [diff] [review]
Patch v1

Review of attachment 734431 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Victor, we need to use the properties that he mentions.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Patch v2

Added font and color.  It looks much better! :)

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: screenshot w/ patch v2

Here's an example after applying patch v2.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 735624 [details] [diff] [review]
Patch v2

Review of attachment 735624 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r+.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/458bbef2075c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/458bbef2075c