Closed Bug 855520 Opened 7 years ago Closed 7 years ago

"No element selected" in the inspector sidebar could use some margins

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: vporof, Assigned: jryans)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached image screenshot
I think that's pretty ugly.

Debugger (and upcoming network monitor) sidebars use am inherited (-moz-box?) font family and size with 4px margins and GrayText.
Blocks: 836233
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
This gives the "No element selected" message the same padding as the rules that appear when something is selected.
Attachment #734431 - Flags: review?(mratcliffe)
Comment on attachment 734431 [details] [diff] [review]
Patch v1

Review of attachment 734431 [details] [diff] [review]:
-----------------------------------------------------------------

You should also use a
>  font: message-box;
and
>  color: GrayText;
for the #noResults element specifically, since that's the style used by every other pane across the developer tools for signaling that "There's nothing here yet".
Comment on attachment 734431 [details] [diff] [review]
Patch v1

Review of attachment 734431 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Victor, we need to use the properties that he mentions.
Attachment #734431 - Flags: review?(mratcliffe)
Attached patch Patch v2Splinter Review
Added font and color.  It looks much better! :)
Attachment #734431 - Attachment is obsolete: true
Attachment #735624 - Flags: review?(mratcliffe)
Attached image screenshot w/ patch v2
Here's an example after applying patch v2.
Comment on attachment 735624 [details] [diff] [review]
Patch v2

Review of attachment 735624 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, r+.
Attachment #735624 - Flags: review?(mratcliffe) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/458bbef2075c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.