855582 - Make various bindings static variables const

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We have JSFunctionSpecs and the like, and we should make all that stuff const.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Make JS_DefineFunctions and JS_DefineProperties take const function specs and property specs respectively.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make the bindings' various spec arrays const, and make the jitinfo structs static.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make the bindings' various spec arrays const, and make the jitinfo structs static.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 730500 [details] [diff] [review]
part 1.  Make JS_DefineFunctions and JS_DefineProperties take const function specs and property specs respectively.

Review of attachment 730500 [details] [diff] [review]:
-----------------------------------------------------------------

Please update https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JS_DefineProperties and https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JS_DefineFunctions with a note similar to what's on https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JS_GetClass to note the interface change.

This lack-of-const has been something that's been around forever, and a whole ton of callers have non-const static data as a result.  At least file a followup or something to add const to all of those?  I'd say better if you did it, but it's really not a good use of your time.

Comment 5

[Boris Zbarsky [:bzbarsky]]

   https://hg.mozilla.org/integration/mozilla-inbound/rev/ec0ffeafb128
   https://hg.mozilla.org/integration/mozilla-inbound/rev/b6771a98037b

and I've updated the documentation.  Please check over that part, because the versioning is... you know.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Oh, and filed bug 857385.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec0ffeafb128
https://hg.mozilla.org/mozilla-central/rev/b6771a98037b