855668 - GC: Rooting in DictionaryHelpers.cpp

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: Proposed changes

Here's a patch to address the rooting hazards reported in DictionaryHelper.cpp.

Comment 1

[Andrew McCreight [:mccr8]]

Comment on attachment 730632 [details] [diff] [review]
Proposed changes

From the hg blame, this is more smaug's territory.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 730632 [details] [diff] [review]
Proposed changes

It is somewhat confusing that documentation
(http://mxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h)
talks about Handle<T>, yet typedef HandleObject/RootedValue are used.

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Olli Pettay [:smaug] from comment #2)

Thanks for the review!

It was discussed and agreed that as xpconnect uses the SM coding style, it would also use the HandleObject rather than Handle<JSObject *> types for rooting as that's what's used inside the engine.

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a420200842e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a420200842e