GC: Rooting in DictionaryHelpers.cpp

RESOLVED FIXED in mozilla23

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

Trunk
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 730632 [details] [diff] [review]
Proposed changes

Here's a patch to address the rooting hazards reported in DictionaryHelper.cpp.
Attachment #730632 - Flags: review?(bobbyholley+bmo)
Comment on attachment 730632 [details] [diff] [review]
Proposed changes

From the hg blame, this is more smaug's territory.
Attachment #730632 - Flags: review?(bobbyholley+bmo) → review?(bugs)

Comment 2

5 years ago
Comment on attachment 730632 [details] [diff] [review]
Proposed changes

It is somewhat confusing that documentation
(http://mxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h)
talks about Handle<T>, yet typedef HandleObject/RootedValue are used.
Attachment #730632 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Olli Pettay [:smaug] from comment #2)

Thanks for the review!

It was discussed and agreed that as xpconnect uses the SM coding style, it would also use the HandleObject rather than Handle<JSObject *> types for rooting as that's what's used inside the engine.
https://hg.mozilla.org/mozilla-central/rev/9a420200842e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(Assignee)

Updated

5 years ago
Blocks: 831379
You need to log in before you can comment on or make changes to this bug.