Closed Bug 855668 Opened 9 years ago Closed 9 years ago
GC: Rooting in Dictionary
Here's a patch to address the rooting hazards reported in DictionaryHelper.cpp.
Attachment #730632 - Flags: review?(bobbyholley+bmo)
Comment on attachment 730632 [details] [diff] [review] Proposed changes From the hg blame, this is more smaug's territory.
Attachment #730632 - Flags: review?(bobbyholley+bmo) → review?(bugs)
Comment on attachment 730632 [details] [diff] [review] Proposed changes It is somewhat confusing that documentation (http://mxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h) talks about Handle<T>, yet typedef HandleObject/RootedValue are used.
Attachment #730632 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2) Thanks for the review! It was discussed and agreed that as xpconnect uses the SM coding style, it would also use the HandleObject rather than Handle<JSObject *> types for rooting as that's what's used inside the engine.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.