Closed Bug 855677 Opened 11 years ago Closed 11 years ago

Defect - "Undefined" displayed instead of "New Tab" in tab title when restarting with show tabs from last time

Categories

(Firefox for Metro Graveyard :: Browser, defect, P1)

Product:
Firefox for Metro Graveyard
Component:
Browser
Platform:
x86
Windows 8
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 23

People

(Reporter: virgil.dicu, Assigned: rsilveira)

References

Details

(Whiteboard: feature=defect c=Tabs_app_bar u=metro_firefox_user p=2)

Attachments

(1 file)

Patch v1
2.86 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130327 Firefox/22.0
http://hg.mozilla.org/mozilla-central/rev/178a4a770bb1

1. Open Metro Firefox
2. Modify following preferences in settings:
a) When Nightly starts, show "tabs from  last time"
b) Always show tabs - "on"
3. Navigate to any page (e.g. mozilla.org)
4. Open a new tab.
5. Restart Metro Firefox

Actual result: Title bar for the new tab page is displayed as "undefined"
Blocks: metrov1it5
No longer blocks: metrov1triage
Priority: -- → P1
QA Contact: jbecerra
Summary: "Undefined" displayed instead of "New Tab" in tab title when restarting with show tabs from last time → Defect - "Undefined" displayed instead of "New Tab" in tab title when restarting with show tabs from last time
Whiteboard: feature=defect c=tbd u=tbd p=tbd
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Hey Rodrigo, what point estimate would you give for this defect?
Flags: needinfo?(rsilveira)
Blocks: 831924
Whiteboard: feature=defect c=tbd u=tbd p=tbd → feature=defect c=Tabs_app_bar u=metro_firefox_user p=tbd
Marco, I've set my initial estimate at 2.
Flags: needinfo?(rsilveira)
Whiteboard: feature=defect c=Tabs_app_bar u=metro_firefox_user p=tbd → feature=defect c=Tabs_app_bar u=metro_firefox_user p=2
Attached patch Patch v1 — — Splinter Review 
Undefined was also being shown for pages with no title, use http://people.mozilla.org/~rsilveira/notitle/ as example.
Attachment #732133 - Flags: review?(mbrubeck)
Attachment #732133 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/9f333a9c1dc0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Flags: needinfo?(jbecerra)
Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130404 Firefox/23.0

Verified fixed using steps in comment 0. Tabs are restored and title is displayed in all situations:
-tabs on top enabled
-tabs on top disabled
-new tab page/no title sites/regular sites
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Went through the following "Defect" for iteration #5 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-13-03-09-27-mozilla-central/

- Went through the test cases provided in Comment 0
- Went through the test cases provided in Comment 3
- Went through the test cases provided in Comment 4
- Ensured that Tabs that are not currently visible in the "App Bar" are also titled correctly (swiping through the tabs)
Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

Went through all of the previous comments and ensured everything worked without any issues.
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: