If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Defect - "Undefined" displayed instead of "New Tab" in tab title when restarting with show tabs from last time

VERIFIED FIXED in Firefox 23

Status

Firefox for Metro
Browser
P1
normal
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: virgil, Assigned: rsilveira)

Tracking

Trunk
Firefox 23
x86
Windows 8
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=defect c=Tabs_app_bar u=metro_firefox_user p=2)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130327 Firefox/22.0
http://hg.mozilla.org/mozilla-central/rev/178a4a770bb1

1. Open Metro Firefox
2. Modify following preferences in settings:
a) When Nightly starts, show "tabs from  last time"
b) Always show tabs - "on"
3. Navigate to any page (e.g. mozilla.org)
4. Open a new tab.
5. Restart Metro Firefox

Actual result: Title bar for the new tab page is displayed as "undefined"
Blocks: 841214

Updated

5 years ago
Blocks: 850809
No longer blocks: 841214
Priority: -- → P1
QA Contact: jbecerra
Summary: "Undefined" displayed instead of "New Tab" in tab title when restarting with show tabs from last time → Defect - "Undefined" displayed instead of "New Tab" in tab title when restarting with show tabs from last time
Whiteboard: feature=defect c=tbd u=tbd p=tbd
(Assignee)

Updated

5 years ago
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Hey Rodrigo, what point estimate would you give for this defect?
Flags: needinfo?(rsilveira)

Updated

5 years ago
Blocks: 831924
Whiteboard: feature=defect c=tbd u=tbd p=tbd → feature=defect c=Tabs_app_bar u=metro_firefox_user p=tbd
Marco, I've set my initial estimate at 2.
Flags: needinfo?(rsilveira)
Whiteboard: feature=defect c=Tabs_app_bar u=metro_firefox_user p=tbd → feature=defect c=Tabs_app_bar u=metro_firefox_user p=2
Created attachment 732133 [details] [diff] [review]
Patch v1

Undefined was also being shown for pages with no title, use http://people.mozilla.org/~rsilveira/notitle/ as example.
Attachment #732133 - Flags: review?(mbrubeck)
Attachment #732133 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f333a9c1dc0
https://hg.mozilla.org/mozilla-central/rev/9f333a9c1dc0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23

Updated

5 years ago
Flags: needinfo?(jbecerra)
(Reporter)

Comment 6

5 years ago
Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130404 Firefox/23.0

Verified fixed using steps in comment 0. Tabs are restored and title is displayed in all situations:
-tabs on top enabled
-tabs on top disabled
-new tab page/no title sites/regular sites
Status: RESOLVED → VERIFIED

Updated

5 years ago
Flags: needinfo?(jbecerra)
Went through the following "Defect" for iteration #5 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-13-03-09-27-mozilla-central/

- Went through the test cases provided in Comment 0
- Went through the test cases provided in Comment 3
- Went through the test cases provided in Comment 4
- Ensured that Tabs that are not currently visible in the "App Bar" are also titled correctly (swiping through the tabs)
Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

Went through all of the previous comments and ensured everything worked without any issues.
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.
You need to log in before you can comment on or make changes to this bug.