Closed Bug 855684 Opened 13 years ago Closed 13 years ago

Use opacity rather than hard-coded colors for signature display

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.19

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(2 files)

This is part of what Thunderbird bug 855135 covers. In both classic and modern themes, .moz-signature is fixed with "color: gray;" for the main signature text and "color #7777FF;" for the link color, thus ignoring any custom settings the user may have chosen for browser.display.foreground_color and unvisited/visited links, browser.anchor_color and browser.visited_color, respectively. The solution is to base the signature appearance not on fixed colors but on opacity instead, thus allowing the original colors to prevail. This affects mostly plain-text messages and HTML messages which don't define own colors.
Attached patch Proposed patch — — Splinter Review
This patch sets opacity to 0.5, corresponding to the 50% gray defined before, thus retaining the previous appearance without any custom colors. Both the classic and modern themes are modified equally, I didn't find any Mac-specific style file, thus I assume that it is covered by the classic CSS definitions.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #730652 - Flags: review?(philip.chee)
Attached image Screenshots —
Comparison of current appearance and with the patch applied, bot default colors and some arbitrary custom colors. ClearType is disabled and View > Message Body > Simple HTML applied to avoid interference of hardware or document colors. The upper row shows a match of the signature appearance with current display, the lower row the correct colors applied now to the signature. Rightmost column is a zoom-in for a better detail comparison.
Comment on attachment 730652 [details] [diff] [review] Proposed patch I'm unsure of the utility of this patch. Setting ui-review to Neil
Attachment #730652 - Flags: ui-review?(neil)
The motivation for this patch is that users see their preferred font colors applied when setting them explicitly in Edit > Preferences > Appearance > Colors, not just for the message body but also for the signature. In general, I don't think that hard-coding colors for content is a good idea. Most people will probably just go with the defaults, and nothing effectively changes for them, but the choice of users who want to apply different color schemes than black/white/blue should be respected and not overridden by the theme.
Comment on attachment 730652 [details] [diff] [review] Proposed patch Seems reasonable to me. (I didn't actually apply the patch, I just used DOM Inspector to tweak the styles in the message pane and observed the result.)
Attachment #730652 - Flags: ui-review?(neil)
Attachment #730652 - Flags: ui-review+
Attachment #730652 - Flags: review?(philip.chee)
Attachment #730652 - Flags: review+
Thanks to both of you, push for trunk please.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → seamonkey2.19
See Also: → 845807
See Also: 845807 → 855135
Depends on: 920997
Depends on: 931484
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: