855712 - [CODE CLEANUP] trailing whitespaces in image/src/*cpp

Status: RESOLVED FIXED

(Core :: Graphics, defect, P5)

Description

[Luis de Bethencourt [:luisbg]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.69 Safari/537.17

Steps to reproduce:

Reading the Graphics code in image/src/ and noticed a lot of trailing whitespaces. My text editor automatically offers me to remove them so decided it is worth sharing and cleaning up.

If there is interest I could clean the code to follow https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style

Comment 1

[Luis de Bethencourt [:luisbg]]

Attachment: trailing whitespaces removed

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 730684 [details] [diff] [review]
trailing whitespaces removed

You shouldn't be setting "review+" on your patch - you need to set "review?" (with an appropriate email address) as a request for a Graphics module owner/peer to review the patch, then they'll change it to "+" or "-" as appropriate.

In this case, I think the main question is whether the cleanup is worth the pollution of history/hg blame that it causes.

Comment 3

[Luis de Bethencourt [:luisbg]]

Jonathan,

Thanks for feedback. I agree that polluting the hg blame is the negative aspect of this cleanup. I wish there was a way to do this kind of cleanups without changing the history/blame of these lines.

I will find somebody else in the Graphics team to assign the review to since Joe is in vacations.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 730684 [details] [diff] [review]
trailing whitespaces removed

Review of attachment 730684 [details] [diff] [review]:
-----------------------------------------------------------------

This is certainly reasonable. Hopefully it doesn't cause Joe any unnecessary pain with bug 716140

Comment 5

[Luis de Bethencourt [:luisbg]]

Attachment: rebased against current trunk and hg formatted

Thanks Jeff for the r+ :)

Comment 6

[Luis de Bethencourt [:luisbg]]

Attachment: rebased and updated

Updated

Comment 7

[Luis de Bethencourt [:luisbg]]

Comment on attachment 731262 [details] [diff] [review]
rebased and updated

Review of attachment 731262 [details] [diff] [review]:
-----------------------------------------------------------------

setting it as checkin:?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 731262 [details] [diff] [review]
rebased and updated

You can just set the checkin-needed keyword at the top in the future. It's a bit easier for me to use.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc53af70fd58

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc53af70fd58