855728 - nsLayoutModule.cpp: error: FakeSpeechRecognitionService.h file not found

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

It seems --disable-tests doesn't produce Makefile for tests/ directory
and the build subsequently fails because 'export' there is never run.

  layout/build/nsLayoutModule.cpp:98:10: fatal error:
	'mozilla/dom/FakeSpeechRecognitionService.h' file not found
  #include "mozilla/dom/FakeSpeechRecognitionService.h"
	   ^
  1 error generated.

Comment 1

[Jan Beich]

Attachment: fix

probably wrong as I haven't tested without --disable-tests

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 730724 [details] [diff] [review]
fix

A build peer review would probably be better. :)

Comment 4

[Boris Zbarsky [:bzbarsky]]

So wait, is it purposeful that we're shipping the fake speech recognition service in our release builds?

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 730724 [details] [diff] [review]
fix

Review of attachment 730724 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 6

[Mike Hommey [:glandium]]

It seems weird to move the .h without the .cpp. And it's weird that the .h is included from  nsLayoutModule.cpp if everything is really meant to be under test/ ?

Comment 7

[Guilherme Gonçalves [:ggp]]

(In reply to Mike Hommey [:glandium] from comment #6)
> It seems weird to move the .h without the .cpp. And it's weird that the .h
> is included from  nsLayoutModule.cpp if everything is really meant to be
> under test/ ?

We include the header in nsLayoutModule so we can have a factory of recognition services (instantiable by CID), the fake one being used only for tests -- hence its files being under test/.

It might not really be necessary to move the file in the patch, as we already use the test directory in the Makefile's VPATH.

Comment 8

[Jan Beich]

Attachment: fix, without moving .h file

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a39cf8abc9c2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a39cf8abc9c2