Closed Bug 855728 Opened 10 years ago Closed 10 years ago

nsLayoutModule.cpp: error: FakeSpeechRecognitionService.h file not found

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 1 obsolete file)

It seems --disable-tests doesn't produce Makefile for tests/ directory
and the build subsequently fails because 'export' there is never run.

  layout/build/nsLayoutModule.cpp:98:10: fatal error:
	'mozilla/dom/FakeSpeechRecognitionService.h' file not found
  #include "mozilla/dom/FakeSpeechRecognitionService.h"
	   ^
  1 error generated.
Attached patch fix (obsolete) — Splinter Review
probably wrong as I haven't tested without --disable-tests
Attachment #730724 - Flags: review?(jschoenick)
Blocks: 650295
No longer depends on: 650295
Comment on attachment 730724 [details] [diff] [review]
fix

A build peer review would probably be better. :)
Attachment #730724 - Flags: review?(jschoenick) → review?(gps)
So wait, is it purposeful that we're shipping the fake speech recognition service in our release builds?
Comment on attachment 730724 [details] [diff] [review]
fix

Review of attachment 730724 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #730724 - Flags: review?(gps) → review+
It seems weird to move the .h without the .cpp. And it's weird that the .h is included from  nsLayoutModule.cpp if everything is really meant to be under test/ ?
(In reply to Mike Hommey [:glandium] from comment #6)
> It seems weird to move the .h without the .cpp. And it's weird that the .h
> is included from  nsLayoutModule.cpp if everything is really meant to be
> under test/ ?

We include the header in nsLayoutModule so we can have a factory of recognition services (instantiable by CID), the fake one being used only for tests -- hence its files being under test/.

It might not really be necessary to move the file in the patch, as we already use the test directory in the Makefile's VPATH.
Attachment #730724 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a39cf8abc9c2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.