Closed Bug 855790 Opened 9 years ago Closed 9 years ago

Clang error: forward declaration of class cannot have a nested name specifier" at gfxPlatformMac.h

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: reuben, Assigned: reuben)

Details

Attachments

(1 file)

Fix Clang error
710 bytes, patch
mattwoodrow
: review+
overholt
: approval-mozilla-b2g18+
Details | Diff | Splinter Review 
On clang version 3.3 (trunk 178068), gfxPlatformMac.h fails to build.
Attached patch Fix Clang error — — Splinter Review 
One line fix.
Attachment #730789 - Flags: review?(matt.woodrow)
Attachment #730789 - Flags: review?(matt.woodrow) → review+
Assignee: nobody → reuben.bmo
https://hg.mozilla.org/mozilla-central/rev/d8ddbb883e3b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Comment on attachment 730789 [details] [diff] [review]
Fix Clang error

Trying approval for b2g18 because this forces me to keep these patches around when working on b2g18 (and anyone with a recent enough Clang).

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Updating Clang.
User impact if declined: None, affects developers on recent Clang versions.
Testing completed: Patch is minimal and has been in central for a while now.
Risk to taking this patch (and alternatives if risky): No risk, warnings-as-errors fix.
String or UUID changes made by this patch: None.
Attachment #730789 - Flags: approval-mozilla-b2g18?
Attachment #730789 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
You need to log in before you can comment on or make changes to this bug.