855830 - this.button is null at chrome://browser/content/browser.js:6605

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 730848 [details] [diff] [review]
Patch

Hm - I think this is covering up a larger issue.

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#666

shows webrtc-status-button as a child of nav-bar.

In Jamun, it looks like webrtc-status-button has been moved to the palette.

Is the webrtc-status-button supposed to be customizable? If not, it needs to be moved out of the palette, and back under nav-bar. We should also make sure other buttons weren't moved in the same way (I suspect the Social API button was).

So, locally, when I moved webrtc-status-button back under nav-bar, the browser chrome tests started just fine.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Move the button outside of the palette

Good point, how's this?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 730924 [details] [diff] [review]
Move the button outside of the palette

This looks good to me!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hey Blair, I could be wrong, but I think it was one of your original patches that moved the webrtc-status-button into the palette. Was there some requirement there that jaws and I don't know about? Or are we OK to move this back under nav-bar?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Mike Conley (:mconley) from comment #5)
> Hey Blair, I could be wrong, but I think it was one of your original patches
> that moved the webrtc-status-button into the palette. Was there some
> requirement there that jaws and I don't know about? Or are we OK to move
> this back under nav-bar?

Actually I don't think it was intentional. I'm pretty sure that the webrtc frontend bits landed after Blair uploaded the initial patch, and debitrotting that patch placed the webrtc button in the wrong position.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/jamun/rev/98c873f5d5c0

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Jared Wein [:jaws] (Vacation 3/30 to 4/7) from comment #6)
> Actually I don't think it was intentional. I'm pretty sure that the webrtc
> frontend bits landed after Blair uploaded the initial patch, and
> debitrotting that patch placed the webrtc button in the wrong position.

This (AFAIK).

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Landed on jamun as https://hg.mozilla.org/projects/jamun/rev/98c873f5d5c0

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Landed on UX as https://hg.mozilla.org/projects/ux/rev/98c873f5d5c0

Comment 11

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/8f4153b311db
https://hg.mozilla.org/mozilla-central/rev/4fae96ad1f12