Closed Bug 855839 Opened 7 years ago Closed 7 years ago

Remove --disable-ion from armv6 mozconfigs

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Once bug 836486 is landed (real soon now) we should turn on ionmonkey for our armv6 builds by updating the armv6 mozconfigs.
Attached patch PatchSplinter Review
Try run is clean at https://tbpl.mozilla.org/?tree=Try&rev=cb653cd963d3. However that may not mean much, as mjrosenb said on IRC:

10:17:31 mjrosenb: before we had a specific armv6 option for tbpl because we statically did all of the hardware compatability checks
10:17:34 mjrosenb: now they are dynamic
10:17:59 mjrosenb: which means tha we aren't actually testing what it would be like to run on an armv6 device
10:18:58 kats: mjrosenb: i'm not sure i understand. do you mean that if we take an armv6 build and run it on an armv7 device it will not use the armv6 codepaths?
10:19:49 mjrosenb: it will use some of them
10:20:15 mjrosenb: actually, on an android device, it may use none of them.
10:21:59 kats: mjrosenb: ok, so on tbpl it won't be testing the armv6 codepaths, but if i take the tbpl build and run it on an actual armv6 device it should be fine, right?
10:22:21 mjrosenb: kats: yes.
10:22:51 kats: ok
10:23:03 kats: i'll make a note of that in the bug, i guess
10:23:12 kats: i still feel we should enable ion on armv6
10:23:52 mjrosenb: yeah, it shouldn't be that hard to switch it back from dynamic checking to static checking
10:24:01 mjrosenb: or just get some armv6 devices
Also CC'ing some people from bug 789373 in case there's still some reason we need this turned off.
Attachment #731870 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/9fe83576713e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.