855916 - Needs a debug pref for testing moz gesture events

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Currently, Moz*Gesture events are always stopped its propagation by browser.js.
https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#771

This makes us hard to test Moz*Getsture event implementation.

We should add a debug pref for it.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 730994 [details] [diff] [review]
Patch

I suspect that the metro browser.js should have a corresponding check so I'm passing the review over to someone that should be able to answer whether it should

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 730994 [details] [diff] [review]
Patch

Review of attachment 730994 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry re-forwarding this to jimm as he's been the one reiewing the simmilar work done in metro.

Comment 3

[Jim Mathies [:jimm]]

Good idea for testing purposes. cc'ing a few people who might be interested in knowing this pref exists.

> I suspect that the metro browser.js should have a corresponding check so I'm
> passing the review over to someone that should be able to answer whether it
> should

We only use one Moz* simple gesture (MozEdgeGesture) so no need at this point.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Could you please use Services.prefs instead of gPrefService?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7433d1d3b23

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f7433d1d3b23