856001 - Built-in file picker dialog does not populate file input

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Load about:config
2. Change ui.allow_platform_file_picker to false
3. Try to attach a patch to Bugzilla

Expected result: Path to file filled in file input widget

Actual result: As of bug 854102, dialog closes but widget remains blank

Additional information:
Error: this.mParentWindow.wrapDOMFile is not a function
Source File: nsFilePicker.js
Line: 129

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/094e09e55a5a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/094e09e55a5a

Comment 4

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 SeaMonkey/2.20a1 ID:20130402102049 c-c:4ad03358510a m-c:e53044984f1b

The bug is not present this hourly build, made from the 7th changeset after the one in comment #3. => VERIFIED

Comment 5

[Tony Mechelynck [:tonymec]]

One unhappy consequence of the push being shortly after the Aurora liftup is that (unless the fix is ported to Aurora), SeaMonkey 2.18 and Fx/Tb 22 will have a half-broken XUL file picker, with bug 854102 fixed but not this one.

Andrea, what do you think? I suggest asking for approval-mozilla-aurora but I'm not sure who is qualified to do approvals in this part of the code.

Comment 6

[Tony Mechelynck [:tonymec]]

s/2.18/2.19/

Comment 7

[Andrea Marchesini [:baku]]

Comment on attachment 731474 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 832923
User impact if declined: Aurora will have a half-broken XUL file picker
Testing completed (on m-c, etc.):  
Risk to taking this patch (and alternatives if risky): none. The patch is quite small and simple.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 731474 [details] [diff] [review]
patch

Is this needed for B2G as well? If so, please nominate for approval-mozilla-b2g18.

Comment 9

[Tony Mechelynck [:tonymec]]

(In reply to Alex Keybl [:akeybl] from comment #8)
> Comment on attachment 731474 [details] [diff] [review]
> patch
> 
> Is this needed for B2G as well? If so, please nominate for
> approval-mozilla-b2g18.

Good question. The answer hangs on the following:
- Do B2G users commonly set ui.allow_platform_file_picker to false (which is not the default)?
- Are B2G builds affected by bug 854102 and this bug? Can someone test that? (I can't).

Comment 10

[Andrea Marchesini [:baku]]

Comment on attachment 731474 [details] [diff] [review]
patch

Bug caused by (feature/regressing bug #): 832923
User impact if declined: This patch doesn't impact b2g directly but would be great to keep in sync the XUL filepicker and the b2g18 one because they have been changed by the patch for bug 832923
Risk to taking this patch (and alternatives if risky): none.

Comment 11

[Andrea Marchesini [:baku]]

> - Do B2G users commonly set ui.allow_platform_file_picker to false (which is
> not the default)?

Yes. There is a custom b2g file picker.

> - Are B2G builds affected by bug 854102 and this bug? Can someone test that?
> (I can't).

No. But aurora needs 854102 to be approved as well.

Comment 12

[Tony Mechelynck [:tonymec]]

(In reply to Tony Mechelynck [:tonymec] from comment #9)
> (In reply to Alex Keybl [:akeybl] from comment #8)
> > Comment on attachment 731474 [details] [diff] [review]
> > patch
> > 
> > Is this needed for B2G as well? If so, please nominate for
> > approval-mozilla-b2g18.
> 
> Good question. The answer hangs on the following:
> - Do B2G users commonly set ui.allow_platform_file_picker to false (which is
> not the default)?
> - Are B2G builds affected by bug 854102 and this bug? Can someone test that?
> (I can't).

Bug 854102 was FIXED (in mozilla22) shortly before the central to aurora merge so the fix is already in current Fx22a2 / Tb22a2 / Sm2.19a2 builds.

Comment 13

[Tony Mechelynck [:tonymec]]

Oops. There was a mid-air collision and Bugzilla seems to have mishandled my "Submit only my new comment" reply.

(In reply to Andrea Marchesini (:baku) from comment #11)
[...]
> No. But aurora needs 854102 to be approved as well.

Bug 854102 was FIXED (in mozilla22) shortly before the central to aurora merge so the fix is already in current Fx22a2 / Tb22a2 / Sm2.19a2 builds.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/929ec80bf557

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 731474 [details] [diff] [review]
patch

approving for XUL sync, should not affect b2g builds.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/b09a1d34b249

Comment 17

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (20130725195523)

When selecting a file, it's name gets displayed next to the Browse button, but it's also added automatically to the Description textbox. Is this by design, or should I file a new bug for it?

Under default conditions, the Description textbox is not modified by selecting a file.