Closed
Bug 856002
Opened 11 years ago
Closed 11 years ago
GCLI requisition update/exec methods should take a DOM node
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: jwalker, Assigned: jwalker)
Details
Attachments
(1 file)
|
9.14 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
Bug 723923 exposes util.execCommand and util.updateCommand, but we can probably do better by having requisition.update take a DOM node from which to take the input. Also this will allow us to fix the potential race condition in how it works now.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jwalker
|
|
Assignee | |
Comment 1•11 years ago
|
||
Bug 839862 adds in the gcli support for this. I'll use this bug for removing the workarounds.
|
|
Assignee | |
Comment 2•11 years ago
|
||
3 functions that were not exposed from GCLI well. Now they are so we can delete them (several times) from Firefox.
Attachment #748877 -
Flags: review?(fayearthur)
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=2669e09ec568
|
||
Updated•11 years ago
|
Attachment #748877 -
Flags: review?(fayearthur) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=6cf5ac92530b https://hg.mozilla.org/integration/fx-team/rev/231636fc3231
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/231636fc3231
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•